> > I make a habit of checking out any interesting kernel changes in full, and 
> > one
> > thing I found in the recent diff by Mr. Wollman for kern_timeout.c is:
> > 
> > +void
> > +callout_init(c)
> > +       struct  callout *c;
> > +{
> > +       bzero(c, sizeof c);
> >  }
> > 
> > That doesn't look correct, does it?
> 
> Agreed.  I think it should be "sizeof *c".

Ahh, I see.  I think it should say

       bzero(c, sizeof(struct callout));

To avoid the compiler using the size of the pointers et. al.


Nate


To Unsubscribe: send mail to majord...@freebsd.org
with "unsubscribe freebsd-current" in the body of the message

Reply via email to