* Jim Bloom <[EMAIL PROTECTED]> [000120 18:02] wrote:
> In you fix below, shouldn't the second block of NTOHx actually be HTONx. I
> realize that this works because the functions are the same, but it should be
> coded correctly.
>
> Jim Bloom
> [EMAIL PROTECTED]
>
> + NTOHL(th->th_seq);
> + NTOHL(th->th_ack);
> + NTOHS(th->th_win);
> + NTOHS(th->th_urp);
> + th->th_sum = in_cksum(m, len);
> + if (th->th_sum) {
> + tcpstat.tcps_rcvbadsum++;
> + goto drop;
> + }
> + NTOHL(th->th_seq);
> + NTOHL(th->th_ack);
> + NTOHS(th->th_win);
> + NTOHS(th->th_urp);
hmm, that's prolly right, i've been on irc trying to discuss this with
people and bit harried.
I'm sure there's a better way to do this, but the idea is to move
the checksum until after the pcb lookup, but i still have to look
at this more.
-Alfred
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
