In article <[EMAIL PROTECTED]>,
Matthew Dillon <[EMAIL PROTECTED]> wrote:
> :1. Do I really need the splnet calls around RTFREE?
>
> Yes. Because the route table may be flushed from an interrupt in
> a low memory situation.
I guess I didn't state the question very well. I realize that RTFREE
has to be executed at splnet. But I think it's likely that rtalloc
and rtalloc_ign are always called at splnet or better. If that's the
case and it's already required, then adding the redundant splnet calls
would be obfuscatory. I'd rather add a comment instead.
> :2. To eliminate all the duplicated code, shall I make rtalloc just
> :call rtalloc_ign(ro, 0UL)? I assume that was avoided originally for
> :performance reasons, but now there's more code than before.
> :
> Hmm. One trick I used in the VM code was to put the common code in an
> inline static function and leave the external functions broken out to
> avoid an unnecessary call chain.
OK, that's a possibility. I was hoping our network-meister (Yo,
Garrett!) would give me a sign as to whether it would be worthwhile or
not.
John
--
John Polstra [EMAIL PROTECTED]
John D. Polstra & Co., Inc. Seattle, Washington USA
"No matter how cynical I get, I just can't keep up." -- Nora Ephron
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
