On Saturday, 3 July 1999 at 14:40:25 -0500, Jim Bryant wrote:
> In reply:
>> On Sat, 3 Jul 1999, Greg Lehey wrote:
>>
>>> I personally think that, in such a case, you'd be justified to commit
>>> it as a temporary measure. Due to the difference in time zones, this
>>> has hit people while I've been asleep. That doesn't mean the commit
>>> would stay, of course, but at least it would save people unnecessary
>>> pain. Note, of course, that I have now committed the correct file,
>>> which I had forgotten last night.
>>>
>>> What do you others think?
>>
>> Was the fix that wasn't yours correct? 'Cause I'd rather have code that
>> doesn't compile than code that compiles but is subtly wrong.
>
> untested code shouldn't be checked in to begin with. such are the
> basics of version control. mistakes happen in any project, but where
> i come from CVS/RCS/etc is for tested and working code.
Note that the case we're talking about here wasn't an issue of
untested code. The code had been tested, and it works. The problem
was that I had forgotten to commit one file.
Normally, after committing a set of changes, I cvsup and do a "make
world". That takes time, of course, and it doesn't stop others from
tripping over the same problem.
> if i made such a mistake, i would be grateful for a temporary kludge
> submitted by someone, assuming they know that it is subject to a
> proper fix at any moment.
Agreed.
Greg
--
See complete headers for address, home page and phone numbers
finger [EMAIL PROTECTED] for PGP public key
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
