https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298964

            Bug ID: 298964
           Summary: release: oci-release should be self-sustaining
           Product: Base System
           Version: Unspecified
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: [email protected]
          Reporter: [email protected]

release/scripts/make-oci-image.sh currently assumes that `make packages` has
constructed a repo in the .OBJDIR via the pkg config it constructs in
init_repo():

```
FreeBSD-base: {                                                                 
  url: "file:///usr/obj${srcdir}/repo/${abi}/latest"                            
  signature_type: "none"                                                        
  fingerprints: "none"                                                          
}                                                                               
```

A useful first change would be to re-position this in terms of OBJROOT /
REPODIR to reflect how Makefile.inc1 does it, to allow custom repository
locations, using definitions like:

: ${OBJROOT:="/usr/obj${srcdir}/"}
: ${REPODIR:="${OBJROOT}repo"}

However, since the OCI build landed, pkgbase has also landed and it should
probably just use a pkgbase repo constructed by the rest of the release build
instead to avoid surprises if the driver of the release process didn't update
the pkgbase repo.  I think that effectively means just two things:

 1. The `oci-release` target grows a dependency on the `pkgbase-repo-dir`
target
 2. init_repo() goes away in favor of using --repo-conf-dir
${.OBJDIR}/pkgbase-repo-dir

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to