https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267028

--- Comment #346 from Mark Millard <marklmi26-f...@yahoo.com> ---
(In reply to George Mitchell from comment #344)

You might want to adjust the text of the panic as well,
so that the wording does not mislead folks reading what
is reported by the panic: no longer suggest the
condition's status.

It looks to me like the code:

        if ((frame->tf_rflags & PSL_I) == 0) {
                /*
                 * Buggy application or kernel code has disabled
                 * interrupts and then trapped.  Enabling interrupts
                 * now is wrong, but it is better than running with
                 * interrupts disabled until they are accidentally
                 * enabled later.
                 */
. . .

would still happen and do:

                        default:
                                printf(
                                    "kernel trap %d with interrupts
disabled\n",
                                    type);

                                /*
                                 * We shouldn't enable interrupts while holding
a
                                 * spin lock.
                                 */
                                if (td->td_md.md_spinlock_count == 0)
                                        enable_intr();

It might be that Andriy was suggesting avoiding parts
of this in some way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to