https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271062
Warner Losh <i...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |i...@freebsd.org
--- Comment #1 from Warner Losh <i...@freebsd.org> ---
I generally like this patch... however...
- isp_prt(isp, ISP_LOGERR, "bad frame length (%d) from NVRAM-
using %d", DEFAULT_FRAMESIZE(isp), ICB_DFLT_FRMLEN);
- icbp->icb_maxfrmlen = ICB_DFLT_FRMLEN;
+ if (IS_28XX(isp)) {
+ isp_prt(isp, ISP_LOGERR, "bad frame length (%d) from
NVRAM - using %d", DEFAULT_FRAMESIZE(isp), ICB_DFLT_FRMLEN_28XX);
+ icbp->icb_maxfrmlen = ICB_DFLT_FRMLEN_28XX;
+ } else {
+ isp_prt(isp, ISP_LOGERR, "bad frame length (%d) from
NVRAM - using %d", DEFAULT_FRAMESIZE(isp), ICB_DFLT_FRMLEN);
+ icbp->icb_maxfrmlen = ICB_DFLT_FRMLEN;
+ }
looks a little ugly to me. I'd be tempted to add a icbp->icb_dflt_frmlen field
where we detect the 2800, set a different value. That way, we'd not need the if
here with the code duplication.
Other than that, the patch looks very good.
--
You are receiving this mail because:
You are the assignee for the bug.
