https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204521

--- Comment #264 from gn...@justmail.de ---
(In reply to Henri Hennebert from comment #256)
(In reply to Henri Hennebert from comment #260)

I can report partial success for 106fb99f7c54616c3e853d942be4c2faf81c6d0b.
There was a bug with RTSX_REVERSE_SOCKET for 5227 and 522A. With that fixed the
card state is again detected successfully and I can access the card. I only
tested booting into FreeBSD after power-on.

-- cut --
diff --git a/rtsx.c b/rtsx.c
index ae599ee..a4518e1 100644
--- a/rtsx.c
+++ b/rtsx.c
@@ -876,7 +876,7 @@ rtsx_init(struct rtsx_softc *sc)
                RTSX_WRITE(sc, RTSX_SD30_CMD_DRIVE_SEL,
driving_3v3[sc->rtsx_sd30_drive_sel_3v3][1]);
                RTSX_WRITE(sc, RTSX_SD30_DAT_DRIVE_SEL,
driving_3v3[sc->rtsx_sd30_drive_sel_3v3][2]);
                /* Configure force_clock_req */
-               if (sc->rtsx_flags | RTSX_REVERSE_SOCKET)
+               if ((sc->rtsx_flags & RTSX_REVERSE_SOCKET) != 0)
                        RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0xB8);
                else
                        RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0x88);
@@ -903,7 +903,7 @@ rtsx_init(struct rtsx_softc *sc)
                RTSX_WRITE(sc, RTSX_SD30_CMD_DRIVE_SEL,
driving_3v3[sc->rtsx_sd30_drive_sel_3v3][1]);
                RTSX_WRITE(sc, RTSX_SD30_DAT_DRIVE_SEL,
driving_3v3[sc->rtsx_sd30_drive_sel_3v3][2]);
                /* Configure force_clock_req */
-               if (sc->rtsx_flags | RTSX_REVERSE_SOCKET)
+               if ((sc->rtsx_flags & RTSX_REVERSE_SOCKET) != 0)
                        RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0xB8);
                else
                        RTSX_BITOP(sc, RTSX_PETXCFG, 0xB8, 0x88);
-- cut --

(In reply to Henri Hennebert from comment #259)
Out of curiosity I activated the vendor code again which still fails but I
suppose that is to be expected without a change in that part of the code. I
forgot to get the lspci output. Are you still interested in that data?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

Reply via email to