https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238730
--- Comment #16 from Andriy Gapon <a...@freebsd.org> ---
(In reply to Dennis Clarke from comment #13)
It's been a while since I last saw a context diff, unified diffs are all rage
now :) I think that the diff does not do what I asked in comment #12. It moves
an assignment not the check.
This is what I meant:
Index: sys/dev/bge/if_bge.c
===================================================================
--- sys/dev/bge/if_bge.c (revision 349883)
+++ sys/dev/bge/if_bge.c (working copy)
@@ -3276,6 +3276,8 @@ bge_mbox_reorder(struct bge_softc *sc)
bus = device_get_parent(dev);
if (device_get_devclass(dev) != pcib)
break;
+ if (device_get_devclass(bus) != pci)
+ break;
for (i = 0; i < nitems(mbox_reorder_lists); i++) {
if (pci_get_vendor(dev) ==
mbox_reorder_lists[i].vendor &&
@@ -3287,8 +3289,6 @@ bge_mbox_reorder(struct bge_softc *sc)
return (1);
}
}
- if (device_get_devclass(bus) != pci)
- break;
}
return (0);
}
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
