https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231881
Bug ID: 231881
Summary: boot0cfg can not configutr "version 1.0" boot0 due to
bug in gpart_mbr bootcode
Product: Base System
Version: CURRENT
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: kern
Assignee: b...@freebsd.org
Reporter: l...@freebsd.org
boot0/boot0sio have disk serial number compiled-in by default. It is named
"version 2" boot block by boot0cfg(8) and this format places 4 byte Disk Serial
Number where "version 1" boot block contains options.
Support for disk serial number in boot0/boot0sio is optional, and could be
turned off to save some bytes, needed for other options.
boot0cfg(8) properly supports old placement of boot block options, properly
detect boot block without disk serial number support and properly prepare
options for it.
Problem is, boot0cfg(8) uses "gpart bootcode" command to wriet boot block with
new options back to disk.
And gmart_mbr always try to save disk serial number, which kills options if
boot block is "version 1":
static int
g_part_mbr_bootcode(struct g_part_table *basetable, struct g_part_parms *gpp)
{
struct g_part_mbr_table *table;
uint32_t dsn;
if (gpp->gpp_codesize != MBRSIZE)
return (ENODEV);
table = (struct g_part_mbr_table *)basetable;
dsn = *(uint32_t *)(table->mbr + DOSDSNOFF);
bcopy(gpp->gpp_codeptr, table->mbr, DOSPARTOFF);
if (dsn != 0)
*(uint32_t *)(table->mbr + DOSDSNOFF) = dsn;
return (0);
}
Sometimes, it leads to complete bogus options written which kill boot0/boot0sio
(it have invalid slice mask, for example, and is unable to boot at all) and
sometimes it simply didn't give user ability to change boot0/boot0sio options.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
