https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210707
Bug ID: 210707 Summary: freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious condition Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: dcb...@hotmail.com 1. freebsd/sys/dev/aacraid/aacraid.c:2854]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. if ((error = copyin((void *)&user_srb->data_len, &fibsize, sizeof (u_int32_t)) != 0)) goto out; Maybe better code if ((error = copyin((void *)&user_srb->data_len, &fibsize, sizeof (u_int32_t))) != 0) goto out; 2. freebsd/sys/dev/aacraid/aacraid.c:2861]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. if ((error = copyin((void *)user_srb, srbcmd, fibsize) != 0)) Maybe better code if ((error = copyin((void *)user_srb, srbcmd, fibsize)) != 0) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"