>Number: 186020
>Category: misc
>Synopsis: adb has params to mtx_init reversed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 22 22:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Alfred Perlstein
>Release: current
>Organization:
Norse Corporation
>Environment:
current
>Description:
Args are in wrong order to mtx_init(9)
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: adb_kbd.c
===================================================================
--- adb_kbd.c (revision 261037)
+++ adb_kbd.c (working copy)
@@ -304,7 +304,7 @@
/* Try stepping forward to the extended keyboard protocol */
adb_set_device_handler(dev,3);
- mtx_init(&sc->sc_mutex,KBD_DRIVER_NAME,MTX_DEF,0);
+ mtx_init(&sc->sc_mutex,KBD_DRIVER_NAME,NULL, MTX_DEF);
cv_init(&sc->sc_cv,KBD_DRIVER_NAME);
callout_init(&sc->sc_repeater, 0);
Index: adb_mouse.c
===================================================================
--- adb_mouse.c (revision 261037)
+++ adb_mouse.c (working copy)
@@ -154,7 +154,7 @@
sc = device_get_softc(dev);
sc->sc_dev = dev;
- mtx_init(&sc->sc_mtx,"ams",MTX_DEF,0);
+ mtx_init(&sc->sc_mtx,"ams",NULL, MTX_DEF);
cv_init(&sc->sc_cv,"ams");
sc->flags = 0;
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
