The following reply was made to PR kern/185395; it has been noted by GNATS.
From: Peter Jeremy <pe...@rulingia.com> To: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <oliv...@cochard.me> Cc: freebsd-gnats-submit <freebsd-gnats-sub...@freebsd.org> Subject: Re: kern/185395: IPv4 Multicast broken in 10.x Date: Thu, 2 Jan 2014 17:47:56 +1100 --s9fJI615cBHmzTOP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014-Jan-01 22:03:36 +0100, Olivier Cochard-Labb=E9 <oliv...@cochard.me>= wrote: >And what about the commit 249925 "Add const qualifier to the dst parameter >of the ifnet if_output method" (Fri Apr 26 12:50:32 2013 UTC) ? > >This commit modify function arpresolve() in sys/netinet/if_ether.c by >replacing: >arpresolve(...,struct sockaddr *dst, ...) >by >arpresolve(...,const struct sockaddr *dst, ...). > >And inside this function there is a call to this macro: >ETHER_MAP_IP_MULTICAST(&SIN(dst)->sin_addr, desten); ETHER_MAP_IP_MULTICAST does left to right assignment - the first argument is only read so this change doesn't affect anything. >=3D> If the 'structure dst' in now a 'const struct dst', can the struct 'd= st' >still be modified by the macro ?? The macro never modified 'dst'. In any case, the compiler tracks 'const' and would raise a compile-time error if something tried to modify dst. --=20 Peter Jeremy --s9fJI615cBHmzTOP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iKYEARECAGYFAlLFC5xfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDBCRjc3QTcyNTg5NEVCRTY0RjREN0VFRUZF OEE0N0JGRjAwRkI4ODcACgkQ/opHv/APuIeGJQCgrnnT3SfB+/6uk0lDzXhIBjfm jOEAoL9KLPmZUm3vuTu+V4oUEkMoBysl =vVA+ -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP-- _______________________________________________ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
