The following reply was made to PR bin/179122; it has been noted by GNATS. From: Mark Johnston <ma...@freebsd.org> To: Oliver Fromme <o...@grabthar.secnetix.de> Cc: Oliver Fromme <o...@secnetix.de>, bug-follo...@freebsd.org Subject: Re: bin/179122: [patch] Fix bug with newsyslog -t Date: Fri, 31 May 2013 11:06:29 -0400
On Fri, May 31, 2013 at 10:40:32AM +0200, Oliver Fromme wrote: > Hi Mark, > > > Thanks for reporting this. I've done some testing and the patch looks > > correct. Have you configured the log file in question to be rotated once > > every hour? If not, then newsyslog -t wouldn't have been working > > properly before either. > > No, this is with the default newsyslog.conf of a fresh > installation. > > I've been using -a and -t together on a different machine > with an older version of stable/9 (about half a year old), > and I never got any such error messages from newsyslog > there. However, I did not verify that the rotation > really worked correctly ... I assumed it did. I only > started to look more closely now that I got those error > messages with the recent version of stable/9. newsyslog -t has never worked properly for rotating logfiles based on mtimes; my fix tried to address that, but as you noticed, there is a problem. :) Aside from the error messages, the behaviour of newsyslog in your case will be the same as before. I will commit your patch later today. Thanks again, -Mark _______________________________________________ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
