The following reply was made to PR bin/161257; it has been noted by GNATS. From: Kostik Belousov <kostik...@gmail.com> To: Mikolaj Golub <to.my.troc...@gmail.com> Cc: John Baldwin <j...@freebsd.org>, bug-follo...@freebsd.org, Robert Watson <rwat...@freebsd.org> Subject: Re: bin/161257: procstat(1): procstat should grow a -l flag to display resource limits Date: Sun, 6 Nov 2011 20:42:34 +0200
--z4ZopSbJjk0xfBpb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 06, 2011 at 08:13:14PM +0200, Kostik Belousov wrote: > On Sun, Nov 06, 2011 at 12:21:29AM +0200, Mikolaj Golub wrote: > >=20 > > On Sat, 5 Nov 2011 16:08:39 +0200 Kostik Belousov wrote: > >=20 > > KB> Please note that we grow the count of resources supported, e.g. > > KB> we got RLIMIT_NPTS and RLIMIT_SWAP for 8.0. At least a comment near > > KB> RLIM_NLIMITS to point anybody adding a new resource, to the kern.p= roc.rlimit > > KB> handler, is useful. > >=20 > > Does this look ok? > >=20 > > http://people.freebsd.org/~trociny/resource.h.patch > No, it completely misses my point. You should request the person to handle > binary compatibility for sysctl, not for the array of names. > It should be done in the course of rlimit.patch. And you can already handle the future structure grow by doing the following: size_t len; len =3D req->oldlen; if (sizeof(limp->pl_rlimit) < len) return (EINVAL); error =3D SYSCTL_OUT(req, limp->pl_rlimit, req->oldlen); >=20 > >=20 > > The update rlimit patch: > >=20 > > http://people.freebsd.org/~trociny/rlimit.1.patch > I have no further comments. --z4ZopSbJjk0xfBpb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk621RoACgkQC3+MBN1Mb4iU7gCeLWHCiUWbqKkRRBl9vpl8VnFs 4QgAoKhuRYBOUNzFxsWqzmsOkOYhuzuv =dN5n -----END PGP SIGNATURE----- --z4ZopSbJjk0xfBpb-- _______________________________________________ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"