>Number: 158398 >Category: misc >Synopsis: <geom/geom.h> includes <sys/sbuf.h> gratuitously >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 28 16:10:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Robert Millan >Release: Debian GNU/kFreeBSD "sid" >Organization: >Environment: >Description: <geom/geom.h> includes <sys/sbuf.h> but doesn't really need it, since struct sbuf s treated as an opaque struct in this file.
Please consider removing this include, in Debian this makes life easier since libsbuf is a separate package and may not be available to <geom/geom.h> users. >How-To-Repeat: >Fix: Patch attached with submission follows: --- a/sys/geom/geom.h +++ b/sys/geom/geom.h @@ -43,7 +43,6 @@ #include <sys/sx.h> #include <sys/queue.h> #include <sys/ioccom.h> -#include <sys/sbuf.h> #include <sys/module.h> struct g_class; >Release-Note: >Audit-Trail: >Unformatted: _______________________________________________ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
