>Number: 153772
>Category: kern
>Synopsis: [ixgbe] [patch] sysctls reference wrong XON/XOFF variables
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Jan 07 19:50:02 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Andrew Boyer
>Release: -current
>Organization:
Avere Systems
>Environment:
N/A
>Description:
ixgbe.c creates sysctls called 'link_xon_rcvd' and 'link_xoff_rcvd', but they
display the transmit statistics instead of the receive statistics. It's a
copy-and-paste error.
>How-To-Repeat:
Found by inspection
>Fix:
Patch attached with submission follows:
--- src/sys/dev/ixgbe/ixgbe.c 2011-01-07 14:29:37.000000000 -0500
+++ src/sys/dev/ixgbe/ixgbe.c 2011-01-07 14:29:17.000000000 -0500
@@ -5460,13 +5460,13 @@
CTLFLAG_RD, &stats->lxontxc,
"Link XON Transmitted");
SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xon_rcvd",
- CTLFLAG_RD, &stats->lxontxc,
+ CTLFLAG_RD, &stats->lxonrxc,
"Link XON Received");
SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_txd",
CTLFLAG_RD, &stats->lxofftxc,
"Link XOFF Transmitted");
SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_rcvd",
- CTLFLAG_RD, &stats->lxofftxc,
+ CTLFLAG_RD, &stats->lxoffrxc,
"Link XOFF Received");
/* Packet Reception Stats */
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
