Hi Andre,
Andre Vehreschild wrote:
Could you also please specify the commit SHA your patch is supposed to apply
to? At current mainline's HEAD it has several rejects which makes reviewing
harder.
I just tried and here it applies cleanly on mainline, except that I get
a bunch of:
Hunk #1 succeeded at 2904 (offset 74 lines).
style of warning, but those hunks still seem to end up at the proper play.
And please attach the patch as plain text. It is html-encoded with several
html-codes, for example a '>' is encoded as '>'. This makes it nearly
impossible to apply.
I don't see this in my email program – and also when looking at
https://gcc.gnu.org/pipermail/gcc-patches/2024-September/663534.html – I
don't see any '>' – also not when looking at the the HTML attachment.
please check the code style of your patch using:
contrib/check_GNU_style.py <your_patch>
It reports several errors with line length and formatting.
Hmm, I only see errors related to tree dump, which seem to be okay:
=== ERROR type #1: there should be exactly one space between function
name and parenthesis (7 error(s)) ===
gcc/fortran/dump-parse-tree.cc:2915:17: fputs (" LOCAL(", dumpfile);
And the following is in the parser – and the spaces are mandatory here:
=== ERROR type #2: there should be no space before closing parenthesis
(1 error(s)) ===
gcc/fortran/match.cc:2758:41: else if (gfc_match ("default ( none
)") == MATCH_YES)
I wonder what's the difference between our email readers. – Can you try
the version from
the mailing list archive?
Cheers,
Tobias
