On Thu, 28 Oct 2021 23:37:59 +0200 Harald Anlauf <anl...@gmx.de> wrote:
> Hi Bernhard, > > Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: > > ping > > [I'll rebase and retest this too since it's been a while. > > Ok if it passes?] > > > > On Sun, 21 Oct 2018 16:04:34 +0200 > > Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > >> gcc/fortran/ChangeLog: > >> > >> 2018-10-21 Bernhard Reutner-Fischer <al...@gcc.gnu.org> > >> > >> * parse.c (clean_up_modules): Free gsym. > this essentially looks fine, but did you inspect the callers? > > With the change to the interface (*gsym -> *&gsym), it could have > effects not visible here due to the explicit gsym = NULL. > > Assuming you checked that, and if it regtests fine, then it is > OK for mainline. The only caller is translate_all_program_units. Since we free only module gsyms, even -fdump-fortran-global is unaffected by this, fwiw. It regtests cleanly and i will push it when the rest is approved. Thanks!
