https://bugzilla.redhat.com/show_bug.cgi?id=2048456



--- Comment #11 from Parag AN(पराग) <panem...@gmail.com> ---
1) The links you gave are not raw file links. The way to share files are to
give raw links.
   so for your package it will be

   SPEC URL:
https://raw.githubusercontent.com/mitradranirban/fbf-mukti-fonts/main/fbf-mukti-fonts.spec
   SRPM URL:
https://raw.githubusercontent.com/mitradranirban/fbf-mukti-fonts/main/fbf-mukti-fonts-3.0.1-3.src.rpm

2) You still not following the way generally people write their font SPEC
files.
   Remove empty lines.
   Source lines though can be written at top but good to write them just before
%fontpkg

   You Must read
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_annotated_spec_template

3) I still don't understand why you need %sourcelist, No Package in Fedora uses
it.

4) You should write changelog entries by adding one empty line between entries.
It will make it more readable.
   See https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs

5) You wrote 
   %global fontsummary      Popular GPLed Bengali OpenType  font 

   This should match with this bug's title where you added "Bangla open source
Opentype font"
   Decide which one you like to write and use same at these both places.

6) You don't need Source1: line
   the way to write fontconfs is
   %global fontconfs  65-0-%{fontpkgname}.conf

7) You should not use 65-0 priority for this font. Its for default font in
Fedora which is Lohit Bengali.
   you can use 66 or 67.

8) your fontconfig file is wrong and not as per the way its supposed to be
written.
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_fontconfig

9) Also, run "rpmlint" command on SRPM and binary RPMS and check if there are
any warnings or errors
   that need to be fixed as well. I will guide on that once your other
packaging issues get fixed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2048456
_______________________________________________
fonts-bugs mailing list -- fonts-bugs@lists.fedoraproject.org
To unsubscribe send an email to fonts-bugs-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/fonts-bugs@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to