I'm on the commit list, and I try to make it a habit to Update before I start any work, so no need for a separate notification, but thanks.
EdB On Fri, Dec 28, 2012 at 12:31 PM, Michael Schmalle <apa...@teotigraphix.com> wrote: > HAH! > > You got me, wow I was so organized starting this project. :) > > I'm looking about 1-2 hours if everything goes right. I hate these but this > is what you get for being a mad scientist sometimes. After this we should be > good to go, I think all the reorganization will make sense. > > I'll let you know when I commit if you aren't watching the commits list. > It's funny, I now remember in the very beginning putting the tests in js and > thinking this doesn't make sense... > > > Mike > > > Quoting Erik de Bruin <e...@ixsoftware.nl>: > >> MIke, >> >> When do you expect this 'mother of all refactors' to land? If 'soon', >> I'll hold off on committing more tests and make them work on the 'new' >> code first, no worries. >> >> And I did mean "org.apache.flex.js", it is the package structure for >> 'compiler.jx.tests'... Maybe that also needs 'a little' refactoring? >> >> EdB >> >> >> >> On Fri, Dec 28, 2012 at 12:15 PM, Michael Schmalle >> <apa...@teotigraphix.com> wrote: >>> >>> Erik, >>> >>> FYI I am doing this refactor right now and it's big, so when you do an >>> svn >>> update, you will have to rub your eyes for a second. I wanted to to do >>> this, >>> now your tests in the 'org.apache.flex.js.internal.js.codegen.goog' gave >>> me >>> the reason. ;-) There is no 'org.apache.flex.js' package, I think you >>> meant >>> 'org.apache.flex.compiler'. :) >>> >>> Before I commit this huge update, I will make sure your tests are running >>> correctly. >>> >>> Mike >>> >>> >>> >>> Quoting Erik de Bruin <e...@ixsoftware.nl>: >>> >>>> Mike, >>>> >>>> While trying to stay out of your hair in the FalconJx code, I thought >>>> I might spend some time translating the tests you wrote for the AS >>>> output to tests for the JS + 'goog' output. I'm doing this by copying >>>> the AS tests, renaming them, converting them to subclasses of the AS >>>> tests and pointing them to the 'GoogBackend' (using the code from your >>>> test class). >>>> >>>> An observation: some methods of JSGoogEmitter rely on 'globals' like >>>> 'classDefinition', which are not set when the methods are called from >>>> the tests. I'm not very familiar with JUnit (or unit testing in >>>> general), so a little pointer on how to fix this would be much >>>> appreciated. >>>> >>>> Meanwhile I'll put all the tests (with the 'assertOut' commented out) >>>> in a 'goog' package in 'org.apache.flex.js.internal.js.codegen'. Maybe >>>> we want to put the 'goog' Emitter classes of the compiler also in a >>>> 'goog' package, to increase the separation between them and other >>>> output types? >>>> >>>> EdB >>>> >>>> >>>> >>>> -- >>>> Ix Multimedia Software >>>> >>>> Jan Luykenstraat 27 >>>> 3521 VB Utrecht >>>> >>>> T. 06-51952295 >>>> I. www.ixsoftware.nl >>>> >>> >>> -- >>> Michael Schmalle - Teoti Graphix, LLC >>> http://www.teotigraphix.com >>> http://blog.teotigraphix.com >>> >> >> >> >> -- >> Ix Multimedia Software >> >> Jan Luykenstraat 27 >> 3521 VB Utrecht >> >> T. 06-51952295 >> I. www.ixsoftware.nl >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
