Yes, working out a way to share this would be good. - Gordon
-----Original Message----- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, December 20, 2012 11:08 PM To: flex-dev@incubator.apache.org Subject: Re: Falcon tests > We need to agree on a way to share utility classes. I had to copy the > EnvProperties class to compiler.jx.tests. Do I just make > compiler.jx.tests dependent on compiler.tests? This sounds good to me. And as soon FalconJx needs to build by a build.xml we can add the dependency as well. > BTW EnvProperties needs a license header and be put in the > org.apache.flex.utils package at the least. Ups.. forgot that.. thanks for mentioning. Added header and moved the class to org.apache.flex.utils. On Thu, Dec 20, 2012 at 3:48 AM, Michael Schmalle <apa...@teotigraphix.com> wrote: > Hi, > > We need to agree on a way to share utility classes. I had to copy the > EnvProperties class to compiler.jx.tests. Do I just make > compiler.jx.tests dependent on compiler.tests? > > BTW EnvProperties needs a license header and be put in the > org.apache.flex.utils package at the least. > > Mike > > > > Quoting Cyrill Zadra <cyrill.za...@gmail.com>: > >> With the current solution you need to set the variables only in >> unittest.properties or did I miss something? It's still possible to >> set environment variables. >> >> First it checks if FLEX_HOME exists set through unittest.properties .. >> if not the it sets env.FLEX_HOME as FLEX_HOME. >> <condition property="sdk" value="${FLEX_HOME}" else="${env.FLEX_HOME}"> >> <isset property="FLEX_HOME" /> >> </condition> >> >> .. what do think about moving unittest.properties one directory up ( >> maybe rename that file to env.properties ) so it can be used for >> compiler, compiler.js (and/or compiler.jx) and compiler.tests. >> >> Cyrill >> >> >> >> On Mon, Dec 17, 2012 at 10:19 AM, Gordon Smith <gosm...@adobe.com> wrote: >>> >>> @Chema This sounds like a good idea to me. I don't like having to >>> set environment variables in two places. >>> >>> - Gordon >>> >>> -----Original Message----- >>> From: Chema Balsas [mailto:jbal...@gmail.com] >>> Sent: Saturday, December 15, 2012 8:22 AM >>> To: flex-dev@incubator.apache.org >>> Subject: Re: Falcon tests >>> >>> @Cyril @Gordon What do you think about updating unittests.properties >>> with the environment values inside the eclipse target for example? >>> This way, running ant eclipse will automatically update the >>> variables and allow to run the tests from within eclipse without >>> having to worry about copying the sdk or update this file... >>> >>> Cheers, >>> Chema >>> >>> 2012/12/15 Gordon Smith <gosm...@adobe.com> >>> >>>> Yep, my fault. Sorry about that! >>>> >>>> - Gordon >>>> >>>> -----Original Message----- >>>> From: Gordon Smith >>>> Sent: Friday, December 14, 2012 4:57 PM >>>> To: flex-dev@incubator.apache.org >>>> Subject: RE: Falcon tests >>>> >>>> I have a feeling I may have updated the sdk trunk when I thought I >>>> was updating branches/develop. I'll try the tests again. >>>> >>>> - Gordon >>>> >>>> -----Original Message----- >>>> From: Chema Balsas [mailto:jbal...@gmail.com] >>>> Sent: Friday, December 14, 2012 4:54 PM >>>> To: flex-dev@incubator.apache.org >>>> Subject: Re: Falcon tests >>>> >>>> > >>>> > Do they pass for you? If a test doesn't pass, I'd like to @Ignore >>>> > it until it passes so that 'ant tests' has all passes. >>>> >>>> >>>> Yes, I only removed the @Ignore from the tests that did pass. The >>>> errors you show were indeed fixed in the sdk. I'll check to see >>>> what might be the problem, but they're currently passing for me. >>>> >>>> >>>> 2012/12/15 Gordon Smith <gosm...@adobe.com> >>>> >>>> > > Do you mean sdk, which is copied to compiler/generated/dist/sdk? >>>> > >>>> > I'm not sure what you're asking. I'm talking about removing the >>>> > copy.sdk that I added here >>>> > >>>> > <target name="eclipse" depends="setup, jflex, antlr, jburg, >>>> > copy.sdk"> >>>> > >>>> > in the build.xml for the compiler project. >>>> > >>>> > > You probably have to update the sdk (branch develop). I think >>>> > > he made >>>> > some sdk changes. >>>> > >>>> > I updated and did 'ant clean' followed by 'ant'. >>>> > >>>> > - Gordon >>>> > >>>> > -----Original Message----- >>>> > From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] >>>> > Sent: Friday, December 14, 2012 2:38 PM >>>> > To: flex-dev@incubator.apache.org >>>> > Subject: Re: Falcon tests >>>> > >>>> > > @czadra: Thanks for making all the tests use a consistent way >>>> > > to find >>>> > the SDK. In your template-unittest.properties file, it seems like >>>> > the four lines for setting the properties shouldn't be commented >>>> > out with #, since anybody making a copy will have to uncomment >>>> > these lines. >>>> > Also, is there any reason why some of the example Windows paths >>>> > use \\ >>>> and others use // ? >>>> > If a single / works, I think that's the simplest. >>>> > >>>> > Ok I'll update it. >>>> > >>>> > > Also, last Friday I made the 'eclipse' target run the 'copy.sdk' >>>> > > target, >>>> > without remembering that 'main' runs' 'eclipse'. So 'ant main' >>>> > (and therefore 'ant') is currently copying the SDK. Can we stop >>>> > doing that >>>> now? >>>> > >>>> > Do you mean sdk, which is copied to compiler/generated/dist/sdk? >>>> > >>>> > > @jbalsas: Thanks for making 'ant tests' run the SWC-building tests. >>>> > However, some of them fail for me: >>>> > >>>> > You probably have to update the sdk (branch develop). I think he >>>> > made some sdk changes. >>>> > >>>> > Cyrill >>>> > >>>> > On Fri, Dec 14, 2012 at 1:48 PM, Gordon Smith <gosm...@adobe.com> >>>> > wrote: >>>> > > @czadra: Thanks for making all the tests use a consistent way >>>> > > to find >>>> > the SDK. In your template-unittest.properties file, it seems like >>>> > the four lines for setting the properties shouldn't be commented >>>> > out with #, since anybody making a copy will have to uncomment >>>> > these lines. >>>> > Also, is there any reason why some of the example Windows paths >>>> > use \\ >>>> and others use // ? >>>> > If a single / works, I think that's the simplest. >>>> > > >>>> > > Also, last Friday I made the 'eclipse' target run the 'copy.sdk' >>>> > > target, >>>> > without remembering that 'main' runs' 'eclipse'. So 'ant main' >>>> > (and therefore 'ant') is currently copying the SDK. Can we stop >>>> > doing that >>>> now? >>>> > > >>>> > > @jbalsas: Thanks for making 'ant tests' run the SWC-building tests. >>>> > However, some of them fail for me: >>>> > > >>>> > > functional.tests: >>>> > > [junit] unittest.properties not found >>>> > > [junit] Env - FLEX_HOME = >>>> > D:\Apache\incubator\flex\sdk\branches\develop >>>> > > [junit] Env - PLAYERGLOBAL_HOME = D:/Apache/prerequisites/player >>>> > > [junit] Env - AIR_HOME = D:/Apache/prerequisites/AdobeAIRSDK >>>> > > [junit] Env - FLASHPLAYER_DEBUGGER = >>>> > D:/Apache/prerequisites/fp_11.1.102.63_archive/11_1r102_63_32bit_ >>>> > deb ug /flashplayer11_1r102_63_win_sa_debug_32bit.exe >>>> > > [junit] Running f.SDKSWCTests >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \ai >>>> > rf >>>> > ramework\compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \ai >>>> > rf >>>> > ramework\src\mx\core\WindowedApplication.as:3513 >>>> > > [junit] Error: Implicit coercion of a value with static >>>> > > type Object >>>> > to a possibly unrelated type DisplayObject. >>>> > > [junit] const win:DisplayObject = e.target; >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] Expected: is <0> >>>> > > [junit] got: <1> >>>> > > [junit] ) >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \ap >>>> > ac >>>> > he\compile-config.xml >>>> > > [junit] >>>> > > [junit] 2795 bytes written to >>>> > C:\Users\gosmith.ADOBENET\apache6960283897331585088.swc in 0.204 >>>> > seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > th >>>> > oringsupport\compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > th >>>> > oringsupport\src\AuthoringSupportClasses.as:41 >>>> > > [junit] Error: Access of possibly undefined property com. >>>> > > [junit] com.adobe.viewsource.ViewSource >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] Expected: is <0> >>>> > > [junit] got: <1> >>>> > > [junit] ) >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > to >>>> > mation\compile-config.xml >>>> > > [junit] >>>> > > [junit] 222031 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation826051595714317936.swc in >>>> > 1.033 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > to >>>> > mation_agent\compile-config.xml >>>> > > [junit] >>>> > > [junit] 92486 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation_agent8444353713056428228.swc >>>> > in >>>> > 0.808 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > to >>>> > mation_air\compile-config.xml >>>> > > [junit] >>>> > > [junit] 33505 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation_air3230476853949970118.swc >>>> > in >>>> > 0.932 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > to >>>> > mation_airspark\compile-config.xml >>>> > > [junit] >>>> > > [junit] 20236 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation_airspark3586066025946163224. >>>> > swc >>>> > in >>>> > 0.746 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au >>>> > to >>>> > mation_dmv\compile-config.xml >>>> > > [junit] >>>> > > [junit] 190945 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation_dmv7706242387563503746.swc >>>> > in >>>> > 0.799 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \au to mation_flashflexkit\compile-config.xml >>>> > > [junit] >>>> > > [junit] 12002 bytes written to >>>> > C:\Users\gosmith.ADOBENET\automation_flashflexkit1312505718849999 >>>> > 629 >>>> > .s >>>> > wc in >>>> > 0.491 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \co >>>> > re >>>> > \compile-config.xml >>>> > > [junit] >>>> > > [junit] 3159 bytes written to >>>> > C:\Users\gosmith.ADOBENET\core2880352323301640809.swc in 0.532 >>>> > seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fl >>>> > as >>>> > h-integration\compile-config.xml >>>> > > [junit] >>>> > > [junit] 29024 bytes written to >>>> > C:\Users\gosmith.ADOBENET\flash-integration6836137019897693988.sw >>>> > c >>>> > in >>>> > 0.547 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fr >>>> > am >>>> > ework\compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fr >>>> > am >>>> > ework\src\mx\collections\ListCollectionView.as:1398 >>>> > > [junit] Warning: variable definition duplicates function >>>> > > parameter: >>>> > events. >>>> > > [junit] var >>>> events:Array >>>> > = updatedItems[j].events; >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fr >>>> > am >>>> > ework\src\mx\utils\SHA256.as:111 >>>> > > [junit] Warning: Initializer value 3144134277 for type 'int' >>>> > > must be >>>> > between -2147483648 and 2147483647 inclusive. An initial value of >>>> > -1150833019 will be used instead. >>>> > > [junit] var h1:int = 0xbb67ae85; >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fr >>>> > am >>>> > ework\src\mx\utils\SHA256.as:113 >>>> > > [junit] Warning: Initializer value 2773480762 for type 'int' >>>> > > must be >>>> > between -2147483648 and 2147483647 inclusive. An initial value of >>>> > -1521486534 will be used instead. >>>> > > [junit] 1005597 bytes written to >>>> > C:\Users\gosmith.ADOBENET\framework7466335620323240831.swc in >>>> > 3.345 seconds >>>> > > [junit] var h3:int = 0xa54ff53a; >>>> > > [junit] ^ >>>> > > [junit] Expected: is <0> >>>> > > [junit] >>>> > > [junit] got: <4> >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \fr >>>> > am >>>> > ework\src\mx\utils\SHA256.as:115 >>>> > > [junit] ) >>>> > > [junit] Warning: Initializer value 2600822924 for type 'int' >>>> > > must be >>>> > between -2147483648 and 2147483647 inclusive. An initial value of >>>> > -1694144372 will be used instead. >>>> > > [junit] var h5:int = 0x9b05688c; >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \ha >>>> > lo >>>> > \compile-config.xml >>>> > > [junit] >>>> > > [junit] 41238 bytes written to >>>> > C:\Users\gosmith.ADOBENET\halo8889190254724156442.swc in 0.127 >>>> > seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \mo >>>> > bi >>>> > lecomponents\compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \mo >>>> > bi >>>> > lecomponents\src\spark\components\View.as:441 >>>> > > [junit] Error: Call to a possibly undefined method Event. >>>> > > [junit] dispatchEvent(new >>>> > > Event("navigatorChanged")); >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] Expected: is <0> >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \mo >>>> > bi >>>> > lecomponents\src\spark\components\View.as:982 >>>> > > [junit] Error: Type was not found or was not a compile-time >>>> > constant: Event. >>>> > > [junit] got: <2> >>>> > > [junit] private function >>>> > application_resizeHandler(event:Event):void >>>> > > [junit] ) >>>> > > [junit] ^ >>>> > > [junit] >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \rp >>>> > c\ >>>> > compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \rp >>>> > c\ >>>> > src\mx\rpc\xml\SchemaMarshaller.as:156 >>>> > > [junit] Warning: variable definition duplicates function >>>> > > parameter: >>>> > value. >>>> > > [junit] var value:* = unmarshaller(rawValue, type, >>>> > restriction); >>>> > > [junit] 391894 bytes written to >>>> > C:\Users\gosmith.ADOBENET\rpc4020703131199917066.swc in 1.269 >>>> > seconds >>>> > > [junit] ^ >>>> > > [junit] Expected: is <0> >>>> > > [junit] >>>> > > [junit] got: <1> >>>> > > [junit] ) >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \sp >>>> > ar >>>> > k_dmv\compile-config.xml >>>> > > [junit] >>>> > > [junit] 15497 bytes written to >>>> > C:\Users\gosmith.ADOBENET\spark_dmv4247945619694088249.swc in >>>> > 0.755 seconds >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \to >>>> > ol >>>> > \compile-config.xml >>>> > > [junit] >>>> > > [junit] >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \to >>>> > ol >>>> > \src\mx\automation\tool\ToolAdapter.as:1903 >>>> > > [junit] Warning: variable definition duplicates function >>>> > > parameter: >>>> > message. >>>> > > [junit] var message:String = "WARNING....... >>>> > somebody called setLastError. This was not tested for >>>> > Marshalling"; >>>> > > [junit] ^ >>>> > > [junit] 110637 bytes written to >>>> > C:\Users\gosmith.ADOBENET\tool8024309300705680535.swc in 1.045 >>>> > seconds >>>> > > [junit] >>>> > > [junit] Expected: is <0> >>>> > > [junit] got: <1> >>>> > > [junit] ) >>>> > > [junit] Loading configuration: >>>> > D:\Apache\incubator\flex\sdk\branches\develop\frameworks\projects >>>> > \to >>>> > ol >>>> > _air\compile-config.xml >>>> > > [junit] >>>> > > [junit] 130905 bytes written to >>>> > C:\Users\gosmith.ADOBENET\tool_air3903286668148252506.swc in >>>> > 1.083 seconds >>>> > > [junit] Tests run: 18, Failures: 6, Errors: 0, Time elapsed: >>>> > > 18.424 >>>> > sec >>>> > > [junit] Test f.SDKSWCTests FAILED >>>> > > >>>> > > Do they pass for you? If a test doesn't pass, I'd like to >>>> > > @Ignore it >>>> > until it passes so that 'ant tests' has all passes. >>>> > > >>>> > > - Gordon >>>> > >>>> >> > > -- > Michael Schmalle - Teoti Graphix, LLC > http://www.teotigraphix.com > http://blog.teotigraphix.com >
