In theory, any new tests should pass, but it is very easy for them to pass on your system and have them fail on other systems. New tests often need some back and forth between systems and OS's to work out any kinks.
On 12/8/12 11:19 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > Thank's Alex, I'll run the test in the day then. > > BTW, that makes me wonder, is it a normal process here to commit tests that > not pass or it's an exception ? > > - Fred > > -----Message d'origine----- > From: Alex Harui > Sent: Sunday, December 09, 2012 8:11 AM > To: flex-dev@incubator.apache.org > Subject: Re: [Mustella] 90 tests failed > > I will investigate the test failures over the next few days. There are two > sets of failures that are troubling that we want to make sure isn't in 4.9. > The rest might be flaws in the tests themselves. > > If you get the same failures with or without the patch, then it is ok to > accept the patch. I know it isn't the safest policy, but I think it is good > enough, especially to not discourage community contributions. > > > On 12/8/12 10:50 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > >> Hi Alex, >> >> What then for the failed tests not relative to AdvancedDataGrid and >> Charts >> ? >> >> I've got no clue how to fix them and some are relative to CSS, except I >> wanted to run the test suite against a patch which modify CSSCondition, >> does >> it worth to test it anyway or I have to wait for someone fix the failed >> tests before ? >> >> - Fred >> >> -----Message d'origine----- >> From: Alex Harui >> Sent: Sunday, December 09, 2012 6:25 AM >> To: flex-dev@incubator.apache.org >> Subject: Re: [Mustella] 90 tests failed >> >> I would ignore AdvancedDataGrid and Charts. The tests are newly donated >> and >> I'm not sure they have been proven to work on both platforms. >> >> I ran the full suite last night and saw the same other errors. >> >> >> On 12/8/12 8:54 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: >> >>> After a closer look, they all failed comparing bitmaps except for the >>> three >>> last where it's a locale resources problem. >>> >>> - Fred >>> >>> -----Message d'origine----- >>> From: Frédéric THOMAS >>> Sent: Sunday, December 09, 2012 5:36 AM >>> To: flex-dev@incubator.apache.org >>> Subject: [Mustella] 90 tests failed >>> >>> Hi, >>> >>> Can someone confirm he recently ran the all test suite with no failed >>> tests >>> ? >>> >>> I just ran it and had 90 tests failed[1] >>> After a quick look at the advanceddatagrid ones, it appear that¹s due to >>> the >>> sort separator comparing bitmaps and the edges of the glyphs too. >>> >>> - Fred >>> >>> [1] >>> > Managers/StyleManager/AdvancedCSS/classSelectors/AdvancedCSS_ClassSelectors_R>> > > u >>> ntimeCSS >>> id_classSelector_basic_style >>> > Managers/StyleManager/AdvancedCSS/classSelectors/AdvancedCSS_ClassSelectors_R>> > > u >>> ntimeCSS >>> id_classSelector_basic_style_neg >>> > Managers/StyleManager/AdvancedCSS/idSelectors/AdvancedCSS_IDSelectors_Runtime>> > > C >>> SS >>> id_multipleTypeSelector_style >>> Managers/ToolTipManager/Properties/ToolTipManager_Properties_spark >>> Spark_ToolTipManager_property_customToolTip_list >>> Managers/ToolTipManager/Properties/ToolTipManager_Properties_spark >>> Spark_ToolTipManager_property_ToolTip_list_disabled >>> PerModuleStyles/BasicTests/loadFonts loadFonts >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> use_grouped_data_mirroring >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> use_grouped_data >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> set_editable_item >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> set_group_item >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> set_both_editable >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> insert_columns >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> insert_columngroup >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> hierarchical_data >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Row_Count_with_ColumnGroups >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Formatting_with_column_groups >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Column_Span >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Header_Renderer >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Custom_Header_Renderer >>> components/AdvancedDataGrid/Properties/advanceddatagrid_columngroup >>> Visibility_of_columns >>> components/AdvancedDataGrid/Properties/adg_mirroring_test >>> property_layoutDirection_ltr >>> components/AdvancedDataGrid/Properties/adg_mirroring_test >>> property_layoutDirection_rtl >>> components/AdvancedDataGrid/Properties/adg_mirroring_test >>> property_layoutDirection_application >>> components/AdvancedDataGrid/Properties/adg_mirroring_test >>> property_layoutDirection_application_ltr >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_draggablecolumns_true >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_draggablecolumns_false >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_applygrouping >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_treeview >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_selectionMode_flat_single >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_selectionMode_flat_multiple >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_selectionMode_tree_singlecell >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_selectionMode_tree_multicells >>> components/AdvancedDataGrid/Properties/advanceddatagrid_properties >>> datagrid_own_properties_selectionMode_tree_displayitemsexpanded >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_vscrollposition >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_vscrollpolicy_off >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_vscrollpolicy_on >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_vscrollpolicy_auto >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_hscrollpolicy_on >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_scrollcont>> > > r >>> olbase >>> propert_hscrollpolicy_off >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_enabled_withdisabledcolor >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_width >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_width_200 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_width_30 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_height >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_height_200 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_height_30 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_x_50 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_x_minus10 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_y_50 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_y_minus10 >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_focusEnabled_true >>> > components/AdvancedDataGrid/Properties/advanceddatagrid_properties_uicomponen>> > > t >>> propert_focusEnabled_false >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles >>> style_headerColors >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles >>> style_verticalGridLines >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_alternatingitemcolors >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_paddingBottom >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_paddingtop >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_paddingleft >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_paddingright >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_userollover >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_verticalalign_top >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_listbase >>> style_verticalalign_bottom >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_borderSides_all >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_borderSides_lr >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_borderStyle_inset >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_borderStyle_outset >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_fontFamily_mxml >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_fontFamily_AS >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_fontWeight >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_fontStyle >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_fontSize >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_dropShadowEnabled >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_shadowDirection >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_shadowDistance >>> components/AdvancedDataGrid/Styles/advanceddatagrid_styles_scrollcontrolbase >>> style_textDecoration >>> components/AdvancedDataGrid/Properties/formatters use_style_function1 >>> components/AdvancedDataGrid/Properties/formatters use_style_function2 >>> components/AdvancedDataGrid/Properties/formatters use_style_function3 >>> components/AdvancedDataGrid/Properties/formatters use_currency_formatter >>> components/AdvancedDataGrid/Properties/formatters use_number_formatter >>> components/AdvancedDataGrid/Properties/formatters use_phone_formatter >>> components/AdvancedDataGrid/Properties/formatters use_date_formatter >>> components/AdvancedDataGrid/Properties/formatters use_zipcode_formatter >>> components/AdvancedDataGrid/Properties/formatters use_grouped_view >>> components/AdvancedDataGrid/Properties/formatters use_columnspan >>> components/Charts/Bubble/Properties/BubbleProperties >>> BubbleSeries_multipleAxes_disabledDays >>> gumbo/components/DropDownList/Properties/DropDownList_Properties_Images >>> DropDownList_Properties_imageTest2 >>> resources/ResourceManager/Methods/ResourceManager_Methods_loadResourceModule >>> RTL_Method_loadResourceModule_SameLocaleSameBundle >>> resources/ResourceManager/Methods/ResourceManager_Methods_loadResourceModule >>> RTL_Method_loadResourceModule_AdditionalLocale1Bundle >>> resources/ResourceManager/Methods/ResourceManager_Methods_loadResourceModule >>> RTL_Method_loadResourceModule_AdditionalLocales3Bundles >>> > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
