On Tue, Dec 4, 2012 at 5:08 PM, Justin Mclean <jus...@classsoftware.com>wrote:
> HI, > > > The reason is that we dont have any Mustella tests for Charts and this > code > > change could potentially affect how charts render. > If we didn't have any tests (ie they might already render differently) > before is it an issue? > > Thanks, > Justin I am not sure I understand your question. Whenever a component changes from State A to State B, we want to run their corresponding tests to check if something fails. Here we have a bunch of components whose test cases were not donated. Ideally, we would want to test them before we release them. Alex is working on getting the Mustella tests for charts donated. I suggest we wait until they are committed before we ship this change. Thanks, Om