On Fri, Nov 2, 2012 at 1:09 PM, Carol Frampton <cfram...@adobe.com> wrote:
> It made it into release/temp and was being flagged in the rat report. I > didn't check the actual gz file. > This is not possible unless the build.xml has changed to include temp.p12 in the source kit in the first place. > > If I am following what you saying, rather then excluding it from the kit, > it should not be copied to release/temp and that would fix the rat issue > and ensure it isn't packaged. No, I mean that the temp.p12 should be excluded from the kit when you do "ant release" I picked up your latest changes and tried it again and I am not able to reproduce what you are seeing. Can you please send me a clear set of steps to reproduce? > Carol > > On 11/2/12 3 :44PM, "Om" <bigosma...@gmail.com> wrote: > > >Carol, > > > >The binary file temp.p12 is created during a local build process (ant > >build). For a release build (ant release), we use a different .p12 file. > > We also exclude the temp.p12 from being packaged in the source kit. Take > >a look at the "source-package" target in build.xml where we exclude > >temp.p12 > > > >And I dont see temp.p12 on SVN as well. > > > >Are you sure this is not something that was created as a result of your > >local "ant build". > > > >Thanks, > >Om > > > >On Fri, Nov 2, 2012 at 12:36 PM, Carol Frampton <cfram...@adobe.com> > >wrote: > > > >> Om, > >> > >> There is a binary in the kit that shouldn't be there. I think it can be > >> removed but I wanted you or Erik to verify. > >> > >> Carol > >> > >> On 11/2/12 2 :47PM, "Om" <bigosma...@gmail.com> wrote: > >> > >> >Carol, > >> > > >> >Are you planning on more changes? It looks like you have fixed pretty > >> >much > >> >all the issues. > >> > > >> >Bertrand, when we cut the next RC, can we take it directly to the IPMC? > >> >Or > >> >should it go through a voting round on this list as usual (I hope not!) > >> > > >> >Thanks, > >> >Om > >> > > >> >On Fri, Nov 2, 2012 at 10:44 AM, Om <bigosma...@gmail.com> wrote: > >> > > >> >> 5. in the distro the NOTICE, LICENSE and DISCLAIMER files are at > >>root > >> >>but > >> >> > >> >>> in svn they are under the installer directory - we pulled them up to > >> >>>root > >> >>> when we packaged everything. > >> >>> > >> >>> > >> >> As I mentioned on general@i.a.o, I have fixed this by modifying the > >> >> structure of the RC9 tag. Please take a look at [1] > >> >> > >> >> I dont think we need to modify the directory structure in trunk for a > >> >> release. Please correct me if I am wrong. > >> >> > >> >> Thanks, > >> >> Om > >> >> > >> >> [1] > >> >> > >> >> > >> > >> > https://svn.apache.org/repos/asf/incubator/flex/utilities/tags/apache-fle > >> >>x-sdk-installer-1.0.8-RC9/ > >> >> > >> > >> > >
