On 8/26/12 12:30 PM, "Carlos Rovira" <carlos.rov...@codeoscopic.com> wrote:
> Hi Alex,
>
> as I see you and Peter was able to deal with Jose Barragan's patches
> vía github, I created this patch in the same way and create the JIRA
> ticket as well (both are referenced from one to another):
>
> JIRA ticket:
> https://issues.apache.org/jira/browse/FLEX-33180#comment-13442150
>
> gihub patch:
> https://github.com/apache/flex/pull/14.patch
>
> LEt me know if you have problems.
>
> Best,
>
> Carlos
>
> PD: As I see that Peter upload the baseline images created, I added it
> as well to the patch. You can decide if that images should be upload
> or not. If Peter did it, I think is the way to go to homogenize all
> the work.
>
Hi Carlos,
The patch only changed 5 files. There were bitmap differences between what
is checked in. It might be that assets have changed in the transition from
FLA assets to FXG assets. The question is whether we should modify the FXG
assets or ignore the differences and change the baselines. And, one bitmap
(itemRenderers/Halo/DataGrid/baselines/custom_headerRenderersAS.png) seems
to be missing its asset. Are you seeing that as well?
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
