On 7/13/12 4 :27PM, "Dave Fisher" <dave2w...@comcast.net> wrote:

>I'm giving my +1 (binding IPMC vote)

Thanks.

>
>(1) I've checked the signatures and md5.
>
>(2) I wanted to run the rat report from the src package but needed to
>change the build.xml:
>
>$ diff build-save.xml build.xml
>1610,1611c1610,1611
><         <antcall target="clean-temp" />
><         <unzip src="${basedir}/out/${source.kit}.zip"
>dest="${basedir}/temp"/>
>---
>>         <!--<antcall target="clean-temp" />
>>         <unzip src="${basedir}/out/${source.kit}.zip"
>>dest="${basedir}/temp"/>-->
>1613c1613
><         <property name="rat.dir" value="${basedir}/temp"/>
>---
>>         <property name="rat.dir" value="${basedir}"/>
>
>I don't think the rat report should be run against a package - it should
>be run against the source tree directly.

The reason I ran it against the package is that not all the source is in
the package, or at least when I started, not all the source was in the
package because not all the source was "source".  I think we've clean
everything up now so we could just do an svn export and put everything in
the zip/tar.  That is something I would change for next time.

>
>(2) I wonder if the build can be simplified and not require as much
>manipulation of environment variables. I'd like to see a helper script or
>App to setup the parameter file: env.properties
>
>There are good examples for some of this, but I really am having trouble
>finding where Adobe installed one components on my Mac.
>
>So I cannot properly set env.FLASHPLAYER_DEBUGGER

I understand the frustration.  We'll have to see if we can get better at
it.  Many of us have several versions for development so we know exactly
where they are.  

>
>(3) There were Java 1.4 vs. Java 5 warnings related to Batik and
>Velocity. It's optional, but some effort ought to be made with the those
>projects to see about updating to the most current versions and managing
>any remaining differences as overrides.
>
>Batik: http://xmlgraphics.apache.org/mail.html#batik-dev
>Velocity: http://velocity.apache.org/mail-lists.html

Yes, very ugly.  Because we have changes in the old version of Batik and
Velocity it isn't easy to upgrade - that's the reason we had to fork them.
 

>
>(4) A bunch of Messages from Extensions Manager:
>
>     [exec] 2012-07-13 13:11:13.693 Adobe Extension Manager
>CS5[20292:903] *** __NSAutoreleaseNoPool(): Object 0xd91e20 of class
>NSCFString autoreleased with no pool in place - just leaking

Haven't seen these before.

Carol

Reply via email to