Justin, Thanks for the feedback. I checked in with the apache headers. I also added a diff download for just integrating the component into the mobile projects only (not the desktop) at http://code.google.com/p/flex-spark-toast/downloads/list if that is better for folks.
I took a second look at the show() logic and not sure what you're seeing. I'll take a swing at a test set and an example project if I get some time tonight. On Wed, Mar 7, 2012 at 4:22 PM, Justin Mclean <jus...@classsoftware.com>wrote: > Hi, > > > The code is available at: > > > http://code.google.com/p/flex-spark-toast/source/browse/#svn%2Ftrunk%2Fflex-spark-toast > > Great contribution. > > A couple of minor points. > 1. Files need an apache header. > 2. I think the logic in the show method regarding !showing and popupTimer > reset may not be correct. Not 100% sure. > 3. A simple example showing how it should typically be used would help. > > I've not done a lot of mobile work so perhaps some of the people on the > list more experienced with writing mobile components can add more feedback. > > The biggest issue I see to having this included in a future SDK is that > there are no tests. As we're waiting on Mustella to be donated it would be > good to see some FlexUnit tests giving the component a workout. > > Before this code was accepted as part of the Flex SDK you would most > likely need to sign and submit a CLA[1]. > > Thanks, > Justin > > 1. http://www.apache.org/licenses/#clas > >
