Hi Anastasia, On Mon, Oct 21, 2024 at 1:10 PM Anastasia Klimchuk <a...@chromium.org> wrote: > > > Since doc/dev_guide/release_process.rst doesn't cover the naming of > > the tarball it might happen again. > > It also doesn't mention that VERSION file and tarball name must be in sync. > > That's good points. What we now have is: the only "parameters" that > humans provide are version name (in VERSION file), and tag (when tag > is created). The tarball is packaged by the build system, and the file > name generated by the pattern to include project name, and version > name. > > But, I think it's worth adding a few lines into the document, the > person doing the release can double-check the name of the file after > it has been generated. > I updated the patch, and the document now covers the tarball name > pattern. Thank you for good idea. > > We started creating .xz from v1.4, it is now the default for build > system, and I think offers better compression. The expected file name > would be flashrom-v1.4.0.tar.xz, would that work for you? > Yes, that works for me. Thanks for your help.
> On Mon, Oct 21, 2024 at 3:33 AM Patrick Rudolph > <patrick.rudo...@9elements.com> wrote: > > > > Hi Anastasia, > > Thanks for helping out here. > > > > I was hoping to find a flashrom-v1.4.0.tar.bz2, if that's not possible > > that's also fine. > > Since doc/dev_guide/release_process.rst doesn't cover the naming of > > the tarball it might happen again. > > It also doesn't mention that VERSION file and tarball name must be in sync. > > I guess it's fine to have both tarballs available for download. > > > > Regards, > > Patrick Rudolph > > > > On Sun, Oct 20, 2024 at 2:05 PM Anastasia Klimchuk <a...@chromium.org> > > wrote: > > > > > > Hello Patrick, > > > > > > Thank you for explaining the issue. > > > Looking through the history of tag names and version names, there have > > > been variations with or without "v" prefix, probably that's how I got > > > confused. > > > > > > I made a patch to settle the names to be with "v" prefix from now on: > > > https://review.coreboot.org/c/flashrom/+/84811 , however this won't > > > change what was in the VERSION file at the tag v1.4.0. > > > > > > I thought I could create an additional tarball manually. As of, > > > checking out the repo by the tag v1.4.0, modifying VERSION file > > > locally to match the tag name, and creating the tarball. > > > > > > Would this help in your situation? > > > There would be two tarballs for 1.4.0 and v1.4.0 available in > > > downloads, but maybe it's fine. > > > > > > On Sat, Oct 19, 2024 at 11:54 PM Patrick Rudolph via flashrom > > > <flashrom@flashrom.org> wrote: > > > > > > > > Hi, > > > > I cannot download v1.4 as it's not on > > > > https://download.flashrom.org/releases/. > > > > There's only 1.4 available for download (missing the *v* prefix), > > > > though that's not matching the tag. > > > > Please fix to not break existing CIs relying on the correct tag. > > > > > > > > Regards, > > > > Patrick Rudolph > > > > _______________________________________________ > > > > flashrom mailing list -- flashrom@flashrom.org > > > > To unsubscribe send an email to flashrom-le...@flashrom.org > > > > > > > > > > > > -- > > > Anastasia. > > > > -- > Anastasia. _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
