Ritul, Avinash, Thank you so much for your work! I am looking forward to reviewing your patches.
When you will be preparing the patch and sending for review, here are our dev guidelines which are useful: https://flashrom.org/dev_guide/development_guide.html On Tue, Aug 27, 2024 at 10:47 PM Guru, Ritul <ritul.g...@amd.com> wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Anastasia, > We have enabled support for GD25LR512ME and can flash AMD BIOS. > @Munduru, Avinash will share the changes for review. Please review those - > thanks > > > Thanks, > Ritul > > -----Original Message----- > From: Guru, Ritul > Sent: Friday, June 21, 2024 5:04 PM > To: Anastasia Klimchuk <a...@chromium.org> > Cc: Munduru, Avinash <avinash.mund...@amd.com>; Kumar, Chaudhary amit > <chaudharyamit.ku...@amd.com>; Vlim <v...@gigadevice.com>; > flashrom@flashrom.org > Subject: RE: [flashrom] Re: Support for GD25LR512ME flash chip. > > Sure, we are looking to fix this issue, we will discuss on approach we are > using and may need few inputs from you. > > Thanks, > Ritul > > -----Original Message----- > From: Anastasia Klimchuk <a...@chromium.org> > Sent: Thursday, June 20, 2024 5:44 PM > To: Guru, Ritul <ritul.g...@amd.com> > Cc: Munduru, Avinash <avinash.mund...@amd.com>; Kumar, Chaudhary amit > <chaudharyamit.ku...@amd.com>; Vlim <v...@gigadevice.com>; > flashrom@flashrom.org > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip. > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi Ritul, > > Nice to meet you! It's really good to have you on this thread. > > My plan for the issue is to find someone from AMD who can fix the issue. I > mentioned this earlier in this thread :) It would be really great if you > could help? > > I think someone from AMD would be in the best position to fix the issue, you > have all the datasheets available and all the hardware. > It seems from the thread you are hitting the issue during a development > process, so perhaps this can be a justification for why this is needed for > business, and why to allocate resources to fix it. > > Some time ago I wrote this doc, maybe it can be useful > https://flashrom.org/how_to_support_flashrom.html#special-appeal-for-companies > Count this as an official invitation to contribute! > > Thank you for your help > > About possible workarounds, I think writing only one layout region has some > chances to work. > > On Thu, Jun 20, 2024 at 4:27 AM Guru, Ritul <ritul.g...@amd.com> wrote: > > > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > > > Hi Avinash, > > > > How did you try to pad the the 16MB file? > > > > > > > > Hi Anastasia, > > > > Is there any plan to support 64MB flashing enabled in flashrom for this > > SPIROM with internal programming? > > > > > > > > > > > > > > > > Thanks, > > > > Ritul > > > > > > > > From: Munduru, Avinash <avinash.mund...@amd.com> > > Sent: Wednesday, June 19, 2024 11:45 PM > > To: Anastasia Klimchuk <a...@chromium.org> > > Cc: Vlim <v...@gigadevice.com>; flashrom@flashrom.org; Guru, Ritul > > <ritul.g...@amd.com> > > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip. > > > > > > > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > > > > > +Ritul > > > > > > > > Regards, > > > > Avinash. > > > > Get Outlook for iOS > > > > ________________________________ > > > > From: Munduru, Avinash <avinash.mund...@amd.com> > > Sent: Saturday, June 15, 2024 2:14 AM > > To: Anastasia Klimchuk <a...@chromium.org> > > Cc: Vlim <v...@gigadevice.com>; flashrom@flashrom.org > > <flashrom@flashrom.org> > > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip. > > > > > > > > Hi Anastasia, > > > > > > > > Thanks for your input I will try looking into this possible solution. > > > > > > > > I already tried the padding solution but it did not work. > > > > > > > > Once again, thank you for mainlining the patch. > > > > > > > > Regards, > > > > Avinash. > > > > > > > > Get Outlook for iOS > > > > ________________________________ > > > > From: Anastasia Klimchuk <a...@chromium.org> > > Sent: Friday, June 14, 2024 8:11:00 PM > > To: Munduru, Avinash <avinash.mund...@amd.com> > > Cc: Vlim <v...@gigadevice.com>; flashrom@flashrom.org > > <flashrom@flashrom.org> > > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip. > > > > > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > As a quick addition to my previous message: > > > > What you also can try, is to create a layout file with the region of > > size 16MB, and then set the option to only write this region. The area > > outside the region will not be modified. > > If you decide to go this way, please read manpage, especially -l and > > -i options https://flashrom.org/classic_cli_manpage.html > > > > On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk <a...@chromium.org> > > wrote: > > > > > > Hello Avinash, > > > > > > Sorry for some delay in response. I was also thinking, what's useful > > > that I could tell you. > > > > > > I understand your idea to shrink the image to 16MB, so that work > > > around the bug which affects images >16MB. However, flashrom checks > > > whether the size of the image is the same as the size of the chip > > > (should throw an error if not). So to write 16MB onto GD25LR512ME > > > which is 64MB, you would need to pad the file, with zeros usually, > > > to make the file 64MB. > > > I don't know whether it would work. Is it possible that you would > > > try (if you have tools to recover your device from failure of > > > course)? Or perhaps you have tried already? > > > > > > On the other hand, some good news: support for chips GD25LR256E, > > > GD251R512ME has been submitted meanwhile. So no need for patching > > > anymore, the patch linked earlier in the thread is merged into main. > > > > > > -- > > > Anastasia. > > > > > > > > -- > > Anastasia. > > > > -- > Anastasia. -- Anastasia. _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
