On 01/08/16 02:56 AM, Erik de Castro Lopo wrote:
HI all,

I think its time for a new release. The current code base is stable
and I've been building it for x86_64/linux, powerpc/linux, armhf/linux,
x86_64/darwin in a Jenkins build bot. I'm pretty sure others have been
building regularly on their platforms of interest

Seems that the default binutils on OS/2 is too old to support AVX2, attached patch works around this. Not the best solution as best would be configure tests, but simple. I'll file a bug about this but it'll be a while before anything is done about it.
After this the build dies with,
util.c: In function 'benchmark_function':
util.c:124:17: error: 'CLOCK_PROCESS_CPUTIME_ID' undeclared (first use in this function)
  clock_gettime (CLOCK_PROCESS_CPUTIME_ID, &start) ;

Would using gettimeofday() be accurate enough? Perhaps simpler just to disable the microbench test on OS/2 as gettimeofday() would require a configure test and OS/2 is a minor platform?
Dave
From 15985f472037734032183a399b5841a09a0dc950 Mon Sep 17 00:00:00 2001
From: Dave Yeo <dave.r.yeo@gmail.com>
Date: Sat, 9 Jan 2016 22:34:44 -0800
Subject: [PATCH] OS/2 currently has too old of a binutils to support AVX2

Signed-off-by: Dave Yeo <dave.r.yeo@gmail.com>
---
 src/libFLAC/include/private/cpu.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/libFLAC/include/private/cpu.h b/src/libFLAC/include/private/cpu.h
index 380f4f0..1e737cb 100644
--- a/src/libFLAC/include/private/cpu.h
+++ b/src/libFLAC/include/private/cpu.h
@@ -79,7 +79,9 @@
     #define FLAC__SSSE3_SUPPORTED 1
     #define FLAC__SSE4_1_SUPPORTED 1
     #define FLAC__AVX_SUPPORTED 1
+#if !defined __OS2__ /* Currently binutils are too old to support AVX2 */
     #define FLAC__AVX2_SUPPORTED 1
+#endif
     #define FLAC__FMA_SUPPORTED 1
   #else /* for GCC older than 4.9 */
     #define FLAC__SSE_TARGET(x)
-- 
2.0.0

_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Reply via email to