-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2014-11-24 9:49 PM, mark4o wrote:
> $ make check ... Original file size 441044 bytes. Compression > level 0, file size 421389 bytes. ./test_compression.sh: line 42: > let: last_size=: syntax error: operand expected (error token is > "=") I can reproduce on MacOS X 10.8.5. It doesn't seem to like the assignment inside the let statement. Possible an issue with the older bash (3.2) Apple ships? The attached patch resolves the issue, and I believe does the same thing. Martin, does this look correct to you? -r -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJUdPRKAAoJEEcAD3uxRB3vxfEH/A75c5UycOYpnC06Kz9f9KM8 xjzWFfVaB8Fl0X7F586BkyRgmwJQK+NrLkb2FR4+m0MdTvpywpVrKSF9KjDc6p5x ruuQSYJje1X8D4mIR/BeZZUJHtY7YIVIOnPoBfocn1lDtd/pEM4gUZxcaH9p5NWZ GACOtdBOYh56RbH86AX5wbWuPADFnUTo2/09zME/3y4q1mPLjuZ5jOhPc3G82s+J kRZSwxAKCE0jTtyk0qVraHOzU3bE2Et9FtbkWjeosEvS9O3bgj1aH+q5+Trhm+mb 6PPWi7npVVunoXfRrWyQieSTBJFrgboL6fYOfr3nOIu+GqJM4z5QQ/jARUwaaaI= =jc02 -----END PGP SIGNATURE-----
>From f4547f06f710910059d173990efb99dc77917ed9 Mon Sep 17 00:00:00 2001 From: Ralph Giles <gi...@thaumas.net> Date: Tue, 25 Nov 2014 13:21:30 -0800 Subject: [PATCH] Use arithmetic compound syntax instead of 'let'. Fixes a synax error with 'make check' on MacOS X. I also fixed the eccentric indent. --- test/test_compression.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_compression.sh b/test/test_compression.sh index 022ff8e..7507024 100755 --- a/test/test_compression.sh +++ b/test/test_compression.sh @@ -38,8 +38,8 @@ for k in 0 1 2 3 4 5 6 7 8 ; do if test ${last_size} -lt ${size} ; then echo "Error : Compression ${last_k} size $last_size >= compression $k size $size." exit 1 - fi - let last_size=${size}+10 + fi + ((last_size=${size}+10)) last_k=${k} rm -f ${fname} - done +done -- 1.8.5.2 (Apple Git-48)
_______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev