Op 20-10-14 om 16:36 schreef Martijn van Beurden:
Op 20-10-14 om 16:31 schreef lvqcl:
But your patch changes only two last presets (-7 and -8) so
-6 stays unchanged. ( IIRC it should have
"tukey(5e-1);partial_tukey(2)" as its apodization string
instead of current "tukey(5e-1)" ).
.... okay, I really don't know how it is possible I missed
that. Sorry. Here's the patch again.
Sadly, it turns out this patch requires another patch to fix the
test_compression.sh test. The LP coefficient approximations
don't work well with the noisy-sine.wav file that is used for
this test. More explanation is provided in the commit description.
>From 8f5becd1c8329c5052cb65c8397ff28dcc58f136 Mon Sep 17 00:00:00 2001
From: Martijn van Beurden <mva...@gmail.com>
Date: Wed, 22 Oct 2014 20:54:13 +0200
Subject: [PATCH] Make test_compression a little more forgiving
The retune of compression levels makes this test fail. This is due
to a few approximations used in the encoder that determine which
LP coefficient should result in the smallest file. Differences are
usually very small, but in my case this resulted in compression
level 6 giving a 3 byte bigger file.
This patch lets the compression test pass even if the a compression
level results in a file that is up to 10 byte larger than the
previous level
---
test/test_compression.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test_compression.sh b/test/test_compression.sh
index 11bd6c3..504bf55 100755
--- a/test/test_compression.sh
+++ b/test/test_compression.sh
@@ -39,7 +39,7 @@ for k in 0 1 2 3 4 5 6 7 8 ; do
echo "Error : Compression ${last_k} size $last_size >= compression $k size $size."
exit 1
fi
- last_size=${size}
+ let last_size=${size}+10
last_k=${k}
rm -f ${fname}
done
--
1.9.1
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
