Erik de Castro Lopo <mle...@mega-nerd.com> wrote: >> 3. FLAC__bitmath_ilog2_wide() cannot be compiled with MSVC: it has >> 'if (v == 0)...' statement followed by a variable (either idx or >> DEBRUIJN_IDX64) definition. But all calls of this function have >> FLAC__ASSERT statements that ensure that its argument is greater >> than 0. So this 'if()' can be removed. > > I'd actuall prefer to remove those ASSERTS, because they get bypassed > for the production compiles anyway.
I thought that these ASSERTs mean that the encoding algorithm ensures: the argument of FLAC__bitmath_ilog2_wide() is always > 0. In this case there's no need to compare it with 0 inside the function. _______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
