On Sun, May 26, 2013 at 2:57 PM, Xiyue Deng <manp...@gmail.com> wrote: > I have also run a `make fullcheck` on Mac OS X 10.8. Only one test fails: > > FLAC__TEST_LEVEL=1 FLAC__TEST_WITH_VALGRIND=no ./test_grabbag.sh > ./test_grabbag.sh: line 39: 1N: value too great for base (error token is "1N") > make[1]: *** [fullcheck] Error 1 > make: *** [fullcheck] Error 2 > > The cause is that in test_grabbag.sh, line 39, it uses `date +%N` to > get nanoseconds, which is unsupported on Mac OS X, and will produce > just N instead of the nanoseconds. I am unable to find an equivalent > in manpages yet. I wonder whether it is acceptable to use second > instead?
Never mind. Seems fullcheck is supposed to be used by maintainers. I just had a round of `make check` without any issues, so I guess it looks good on Mac OS X. > > On Sun, May 26, 2013 at 11:00 AM, Martijn van Beurden <mva...@gmail.com> > wrote: >> On 26-05-13 11:33, Erik de Castro Lopo wrote: >>> [...] >>> I am now going to do a little testing (and encourage anyone else to do >>> the same) and hopefully release in the next day or so. >> >> I've ran make fullcheck on >> - x86_64-linux-gnu >> - arm-linux-gnueabihf (Raspbian) >> - i686-pc-mingw32 >> - MSVC 2012 (tested by replacing binaries built with i686-pc-mingw32 and >> running test again) >> >> All tests passed, except the thing mentioned below. When disabling the >> checks for --skip and --until, it passes. >> >> I've found one non-critical bug on MSVC and minGW that I didn't get >> earlier because I didn't run fullcheck on Windows yet. In test_flac.sh, >> I got this >> >>> round-trip test (rt-8-8-111.wav->oggflac->oggflac->wav) encode... >>> re-encode... decode... compare... OK >>> round-trip test (rt-8-8-4777.wav->oggflac->oggflac->wav) encode... >>> re-encode... decode... compare... OK >>> testing --skip=# (encode) (raw<->flac)... OK >>> testing --skip=mm:ss (encode) (raw<->flac)... OK >>> testing --skip=mm:ss.sss (encode) (raw<->flac)... Type "flac" for a >>> usage summary or "flac --help" for all options >>> make[1]: Leaving directory `/home/Martijn/flac-ag/test' >> >> When trying to do this by hand, I get this >> >>> >flac.exe -d "C:\Users\Martijn\Music\file.flac" --skip=00:01.11 >>> >>> flac 1.3.0, Copyright (C) 2000-2013 Josh Coalson & Xiph.Org Foundation >>> flac comes with ABSOLUTELY NO WARRANTY. This is free software, and >>> you are welcome to redistribute it under certain conditions. Type >>> `flac' for details. >>> >>> ERROR: invalid value for --skip >>> Type "flac" for a usage summary or "flac --help" for all options >> >> Apparently there's something with the dot there that doesn't work in >> Windows, because using skip with only minutes and seconds (and no >> fraction) works. >> >> I don't think this is critical enough to delay a release however. >> _______________________________________________ >> flac-dev mailing list >> flac-dev@xiph.org >> http://lists.xiph.org/mailman/listinfo/flac-dev _______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
