This patch fixes the issue mentioned below.
On 09-04-13 21:18, Martijn van Beurden wrote:
Hi all,
For testing a few mingw-builds I tried to use ./configure
--disable-thorough-testing (because testing in a virtual machine
through mingw isn't really fast) but it turned out this setting
doesn't do anything.
It turns out these configuration options aren't passed to the test
scripts at all. I do not fully understand how Makefiles or environment
variables work, but my test/Makefile has the following lines
FLAC__TEST_LEVEL = 0
FLAC__TEST_WITH_VALGRIND = no
[...]
TESTS_ENVIRONMENT = FLAC__TEST_LEVEL=0 FLAC__TEST_WITH_VALRGIND=no
However, when I added the following line at the bottom of
test/test_streams.sh
echo "Test level was $FLAC__TEST_LEVEL"
the output I got was "Test level was 1". I traced it back to
if [ x"$FLAC__TEST_LEVEL" = x ] ; then
FLAC__TEST_LEVEL=1
fi
It turns out $FLAC__TEST_LEVEL is unset in the test scripts. As I said
before, I'm not sure how to fix this. This is probably also the case
for $FLAC__TEST_WITH_VALGRIND
>From 064280c51fd476758533bc22b6ace48f1b49735d Mon Sep 17 00:00:00 2001
From: Martijn van Beurden <mva...@gmail.com>
Date: Sun, 21 Apr 2013 22:05:26 +0200
Subject: [PATCH] Fixes setting test level and valgrind testing
This should enable using the disable-thorough-tests,
enable-exhaustive-tests and enable-valgrind-testing
configure switches, because setting these didn't do
anything
---
test/Makefile.am | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/test/Makefile.am b/test/Makefile.am
index 9bc3b1e..0b50b56 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -15,7 +15,7 @@
# restrictive of those mentioned above. See the file COPYING.Xiph in this
# distribution.
-TESTS_ENVIRONMENT = FLAC__TEST_LEVEL=@FLAC__TEST_LEVEL@ FLAC__TEST_WITH_VALRGIND=@FLAC__TEST_WITH_VALGRIND@
+TESTS_ENVIRONMENT = FLAC__TEST_LEVEL=@FLAC__TEST_LEVEL@ FLAC__TEST_WITH_VALGRIND=@FLAC__TEST_WITH_VALGRIND@
SUBDIRS = cuesheets flac-to-flac-metadata-test-files metaflac-test-files pictures
@@ -31,13 +31,13 @@ check_SCRIPTS = \
# This one should pass when building out-of-tree (eg 'make distcheck').
check: $(check_SCRIPTS)
- $(srcdir)/test_libFLAC.sh
+ $(TESTS_ENVIRONMENT) $(srcdir)/test_libFLAC.sh
if FLaC__WITH_CPPLIBS
- $(srcdir)/test_libFLAC++.sh
+ $(TESTS_ENVIRONMENT) $(srcdir)/test_libFLAC++.sh
endif
- $(srcdir)/test_seeking.sh
- $(srcdir)/test_streams.sh
- $(srcdir)/test_compression.sh
+ $(TESTS_ENVIRONMENT) $(srcdir)/test_seeking.sh
+ $(TESTS_ENVIRONMENT) $(srcdir)/test_streams.sh
+ $(TESTS_ENVIRONMENT) $(srcdir)/test_compression.sh
@echo "----------------"
@echo "All tests passed"
@echo "----------------"
@@ -46,16 +46,16 @@ endif
# In particular test_grabbag.sh, test_flac.sh and test_metaflac.sh will not
# run correctly out-of-tree.
fullcheck: $(check_SCRIPTS)
- ./test_libFLAC.sh
+ $(TESTS_ENVIRONMENT) ./test_libFLAC.sh
if FLaC__WITH_CPPLIBS
- ./test_libFLAC++.sh
+ $(TESTS_ENVIRONMENT) ./test_libFLAC++.sh
endif
- ./test_grabbag.sh
- ./test_flac.sh
- ./test_metaflac.sh
- ./test_seeking.sh
- ./test_streams.sh
- ./test_compression.sh
+ $(TESTS_ENVIRONMENT) ./test_grabbag.sh
+ $(TESTS_ENVIRONMENT) ./test_flac.sh
+ $(TESTS_ENVIRONMENT) ./test_metaflac.sh
+ $(TESTS_ENVIRONMENT) ./test_seeking.sh
+ $(TESTS_ENVIRONMENT) ./test_streams.sh
+ $(TESTS_ENVIRONMENT) ./test_compression.sh
@echo "----------------"
@echo "All tests passed"
@echo "----------------"
--
1.7.10.4
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
