On Thu, Apr 09, 2020 at 01:16:16PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-04-09):
> > From: Limin Wang <lance.lmw...@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> > ---
> >  doc/filters.texi          |  3 +++
> >  libavfilter/af_loudnorm.c | 54 +++++++++++++++++++++++++++++++++++++--
> >  2 files changed, 55 insertions(+), 2 deletions(-)
> 
> NACK.
> 
> If we are doing something like that, we should be doing it in a way that
> works for all filters that output statistics, not just one: common
> options name and syntax, common code.
> 
> Doing it that way will only result in similar filters having different
> features in a way that no user can understand.
> 
> Same for the compact output.

My patch set try to make the loudnorm filter easy to use for end user if they
want to process the volume in two pass. I have no clue how to make it common
yet.


> 
> Regards,
> 
> -- 
>   Nicolas George



-- 
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to