Quoting Andreas Rheinhardt (2020-04-06 11:05:50)
> Moritz Barsnick:
> > On Sun, Apr 05, 2020 at 17:59:28 +0200, Andreas Rheinhardt wrote:
> >> - if ((t = av_dict_get(c->metadata, "title", NULL, 0))) {
> >> + if (t = av_dict_get(c->metadata, "title", NULL, 0)) {
> >
> > Isn't the extra set of brackets there to tell the compiler that the
> > assignment is on purpose?
> >
> The assignment is already on purpose without these extra brackets.
> (What compiler thinks it is not on purpose? By "thinks" you mean: emits
> a warning for this (because of potential confusion with ==), don't you?
> If so, you should already get thousands of warnings when compiling FFmpeg.)
See 440e3b2f7f39487f2bc2c12f91126e1bc33d6954 and -Wparentheses
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
