On Wed, Apr 1, 2020 at 6:17 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Tue, Mar 31, 2020 at 05:32:41PM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan <gautamr...@gmail.com> > > > > This patch adds functional changes to support the > > PPT marker. > > --- > > libavcodec/jpeg2000dec.c | 85 +++++++++++++++++++++++++++++++++++----- > > 1 file changed, 76 insertions(+), 9 deletions(-) > > can you explain why the jpeg2000_decode_packet* function is / needs to be > split for this ? > iam asking as it duplicates quite some code in the previous patch > so, if we can represent packet header as H and data as D, without a PPT marker, the packet data is represented as HDHDHDHD..... However, with the PPT marker, this is changed to HHHHHHHHHDDDDDDD..... The jpeg2000_decode_packet() decodes a packet in the HD format. However, to decode packets in packed form (this change should apply even if PPM marker support is added), I thought it would be better if we break the function to decode header and data separately. > thanks > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If a bugfix only changes things apparently unrelated to the bug with no > further explanation, that is a good sign that the bugfix is wrong. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
-- ------------- Gautam | _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
