On Thu, Mar 26, 2020 at 01:41:44AM +0100, Andreas Rheinhardt wrote: > Matroska is built around the principle that a reader does not need to > understand everything in a file in order to be able to make use of it; > it just needs to ignore the data it doesn't know about. > > Our demuxer typically follows this principle, but there is one important > instance where it does not: A Block belonging to a TrackEntry with no > associated stream is treated as invalid data (i.e. the demuxer will try > to resync to the next level 1 element because it takes this as a sign > that it has lost sync). Given that we do not create streams if we don't > know or don't support the type of the TrackEntry, this impairs this > demuxer's forward compability. > > Furthermore, ignoring Blocks belonging to a TrackEntry without > corresponding stream can (in future commits) also be used to ignore > TrackEntries with obviously bogus entries without affecting the other > TrackEntries (by not creating a stream for said TrackEntry). > > Finally, given that matroska_find_track_by_num() already emits its own > error message in case there is no TrackEntry with a given TrackNumber, > the error message (with level AV_LOG_INFO) for this can be removed. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com> > --- > libavformat/matroskadec.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-)
does this affect the efficiency of the demuxer to resync in case of actual errors ? if so it may make sense to check the format version before accepting unreferenced track numbers thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger. -- Epictetus
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
