On Wed, Jan 29, 2020 at 06:00:16PM +0100, Anton Khirnov wrote: > Decoders are supposed to export stream properties in AVCodecContext, the > AVFrame properties are set from those in ff_get_buffer(). > --- > libavcodec/sbcdec.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/sbcdec.c b/libavcodec/sbcdec.c > index d8ea6855fe..2ebde46627 100644 > --- a/libavcodec/sbcdec.c > +++ b/libavcodec/sbcdec.c > @@ -324,6 +324,8 @@ static int sbc_decode_init(AVCodecContext *avctx) > SBCDecContext *sbc = avctx->priv_data; > int i, ch; > > + avctx->sample_fmt = AV_SAMPLE_FMT_S16P; > + > sbc->frame.crc_ctx = av_crc_get_table(AV_CRC_8_EBU); > > memset(sbc->dsp.V, 0, sizeof(sbc->dsp.V)); > @@ -348,9 +350,8 @@ static int sbc_decode_frame(AVCodecContext *avctx, > if (frame_length <= 0) > return frame_length; > > - avctx->channels = > - frame->channels = sbc->frame.channels; > - frame->format = AV_SAMPLE_FMT_S16P; > + avctx->channels = sbc->frame.channels; > +
probably ok but the design of exporting data which describes the current frame in the main context instead of the frames context. It gives a moment pause not feeling that this is the ideal design thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
