Quoting James Almer (2020-02-20 17:26:00)
> Signed-off-by: James Almer <jamr...@gmail.com>
Commit message is now misleading since it will only enable prft if it's
not disabled.
> ---
> Now it can be overriden if you explicitly set write_prft to 0.
>
> libavformat/dashenc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index a52cbc9113..7032adc84d 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -1394,6 +1394,12 @@ static int dash_init(AVFormatContext *s)
> c->frag_type = FRAG_TYPE_EVERY_FRAME;
> }
>
> + if (c->write_prft < 0) {
> + c->write_prft = c->ldash;
nit: !!, in case ldash becomes something else than a bool in the future
> + if (c->ldash)
> + av_log(s, AV_LOG_INFO, "Enabling Producer Reference Time element
> for Low Latency mode\n");
I'd say this should be VERBOSE, since a normal run with no unexpected
events should produce no log output.
Otherwise LGTM.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
