Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

[Gyan]

On 28-01-2020 02:33 pm, Hendrik Leppkes wrote:

On Tue, Jan 28, 2020 at 9:55 AM Gyan <ffm...@gyani.pro> wrote:

On 28-01-2020 01:37 pm, Hendrik Leppkes wrote:

On Tue, Jan 28, 2020 at 8:46 AM Gyan Doshi <ffm...@gyani.pro> wrote:

---
   libavformat/mov.c   | 6 +++---
   libavformat/utils.c | 2 +-
   2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 064fa88137..064d2b5f6e 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -8062,15 +8062,15 @@ static const AVOption mov_options[] = {
   };

   static const AVClass mov_class = {
-    .class_name = "mov,mp4,m4a,3gp,3g2,mj2",
+    .class_name = "qt,isobmff",
       .item_name  = av_default_item_name,
       .option     = mov_options,
       .version    = LIBAVUTIL_VERSION_INT,
   };

   AVInputFormat ff_mov_demuxer = {
-    .name           = "mov,mp4,m4a,3gp,3g2,mj2",
-    .long_name      = NULL_IF_CONFIG_SMALL("QuickTime / MOV"),
+    .name           = "qt,isobmff",
+    .long_name      = NULL_IF_CONFIG_SMALL("QuickTime / ISO Base Media File 
Format"),
       .priv_class     = &mov_class,
       .priv_data_size = sizeof(MOVContext),
       .extensions     = "mov,mp4,m4a,3gp,3g2,mj2,psp,m4b,ism,ismv,isma,f4v",

These names are strictly speaking part of the ABI, and I'm sure that
some applications will use them to identify a format - I know that I
do, for example.

So, this has to be done with the next major bump for lavf?

Whats the advantage in renaming them at all?

Accuracy, but it's just a nitpick.

Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".