On Tue, Jan 21, 2020 at 07:48:38PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2019-12-30 00:38:17)
> > This allows the fuzzer to target meaningfull codec tags instead
> > of hunting the 4gb space, which it seems to have problems with.
> >
> > Suggested-by: James
> > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> > ---
> > libavcodec/avcodec.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 119b32dc1f..b0c6a8f2e3 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -3634,6 +3634,12 @@ typedef struct AVCodec {
> > * The user can only access this field via avcodec_get_hw_config().
> > */
> > const struct AVCodecHWConfigInternal **hw_configs;
> > +
> > + /**
> > + * List of supported codec_tags, terminated by CODEC_TAGS_END.
> > + */
> > + const uint32_t *codec_tags;
> > +#define CODEC_TAGS_END -1
>
> Is this supposed to be public or for fuzzer use only?
> If the latter, then CODEC_TAGS_END doesn't need to live in a public
> header.the codec_tag field is public. So eventually the list of valid codec tags should become too. In this initial patch codec_tags was not really intended to be public and i can certainly move CODEC_TAGS_END to a internal header if preferred. but this is a change that we will likely undo in the future ... Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
