> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Thursday, January 16, 2020 9:31 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-video: add two tests for > dnn_processing with frame format rgb24 and grayf32 > > On 1/14/2020 11:34 AM, Pedro Arthur wrote: > > Hi, > > > > Em qua., 8 de jan. de 2020 às 03:52, Guo, Yejun <yejun....@intel.com> > escreveu: > >> > >> Signed-off-by: Guo, Yejun <yejun....@intel.com> > >> --- > >> tests/fate/filter-video.mak | 4 ++ > >> ...filter-dnn_processing-halve_first_channel_float | 55 > ++++++++++++++++++++++ > >> .../fate/filter-dnn_processing-halve_gray_float | 55 > ++++++++++++++++++++++ > >> 3 files changed, 114 insertions(+) > >> create mode 100644 > tests/ref/fate/filter-dnn_processing-halve_first_channel_float > >> create mode 100644 > tests/ref/fate/filter-dnn_processing-halve_gray_float > >> > >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > >> index 2da27f7..02986b5 100644 > >> --- a/tests/fate/filter-video.mak > >> +++ b/tests/fate/filter-video.mak > >> @@ -259,6 +259,10 @@ FATE_FILTER_SAMPLES-$(call ALLYES, > PNG_DECODER APNG_DEMUXER FORMAT_FILTER COLOR_ > >> FATE_FILTER_VSYNTH-$(CONFIG_PHASE_FILTER) += fate-filter-phase > >> fate-filter-phase: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf phase > >> > >> +FATE_FILTER_VSYNTH-$(CONFIG_DNN_PROCESSING_FILTER) += > fate-filter-dnn_processing-halve_first_channel_float > fate-filter-dnn_processing-halve_gray_float > >> +fate-filter-dnn_processing-halve_first_channel_float: CMD = framecrc -c:v > pgmyuv -i $(SRC) -vf > format=rgb24,dnn_processing=model=$(TARGET_SAMPLES)/dnn_processing/h > alve_first_channel_float.model:input=dnn_in:output=dnn_out:dnn_backend=n > ative > >> +fate-filter-dnn_processing-halve_gray_float: CMD = framecrc -c:v pgmyuv > -i $(SRC) -vf > format=grayf32,dnn_processing=model=$(TARGET_SAMPLES)/dnn_processing/ > halve_gray_float.model:input=dnn_in:output=dnn_out:dnn_backend=native > >> + > >> FATE_REMOVEGRAIN += fate-filter-removegrain-mode-00 > >> fate-filter-removegrain-mode-00: CMD = framecrc -c:v pgmyuv -i $(SRC) > -frames:v 1 -vf removegrain=0:0:0 > >> > > LGTM > > Pushed, thanks. > > fate-filter-dnn_processing-halve_first_channel_float is failing on msvc > x86_64 > http://fate.ffmpeg.org/report.cgi?time=20200114203009&slot=x86_64-msvc1 > 5-windows-native > > If these tests use floats, shouldn't they use tiny_ssim or similar > solutions for float tests in FATE?
thanks for let me know the issue. the 'float' in 'fate-filter-dnn_processing-halve_first_channel_float' means the dnn module accepts float as input, it might not relative to ssim. The issue found in msvc is: [swscaler @ 000000B0CEECF000] No accelerated colorspace conversion found from yuv420p to rgb24. The reason is that the command line includes a video filter 'format' as: CMD = framecrc -c:vpgmyuv -i $(SRC) -vf format=rgb24,dnn_processing=model=.../halve_first_channel_float.model... I just know that yuv420p to rgb24 is missed on msvc, looks that I must enable this test when 'format' is also there. Will try the fix, thanks. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".