James Almer: > On 12/24/2019 10:00 AM, Andreas Rheinhardt wrote: [...] >> >> I have just found out that the webm_chunk muxer takes lots of >> liberties with our API: It does not use the typical API muxing >> functions (avformat_write_header etc.), but instead calls the function >> pointers on its own (is this even legal outside of mux.c?). webm_chunk >> has been written at a time when init and deinit did not exist yet, so >> they are never called. This wasn't really a problem until the Matroska >> muxer switched to using an explicit deinit function in 982a98a0. Now >> there is a memleak. And if this patchset got merged now, it would >> absolutely break the webm_chunk muxer, because it moves several >> allocations to the init function. So the webm_chunk muxer needs to be >> fixed first. > > Who's the maintainer for it? He should be CC'd.
MAINTAINERS doesn't contain an entry for it, but the creator is Vignesh Venkatasubramanian (vigne...@google.com). I added him as a cc to this very mail*. But I don't know whether he still works at google and reads mails for this address. - Andreas *: The patchset that is referred to in the above quote is this: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-November/252578.html Starting with the "Use random TrackUID" patch several allocations are moved to the init function and would no longer be called by webm_chunk; this would break the webm_chunk muxer. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
