Hi James,
Some of the changes are on lines right next to each other, and will cause
conflict... I could make it a separate commit...
Would that work?
So, I would make docs into two separate commits and the code already has
two commits... so overall 4 commits in succession.
Would this work?
Thank you,
Wonkap
On Tue, Dec 17, 2019 at 5:59 PM James Zern <jzern-at-google....@ffmpeg.org>
wrote:
> Hi,
>
> On Mon, Dec 16, 2019 at 2:21 PM Wonkap Jang
> <wonkap-at-google....@ffmpeg.org> wrote:
> >
> > Documentation change for adding support for encoding
> > with temporal scalability in VP9.
> > ---
>
> This part sounds related to the other patches you're sending. The
> documentation can be added with the code change for vp9.
>
> > doc/encoders.texi | 23 ++++++++++++++++++-----
> > 1 file changed, 18 insertions(+), 5 deletions(-)
> >
> > diff --git a/doc/encoders.texi b/doc/encoders.texi
> > index 4ee518a124..7efc446a6c 100644
> > --- a/doc/encoders.texi
> > +++ b/doc/encoders.texi
> > [...]
> > ffmpeg -i INPUT -c:v libvpx -ts-parameters ts_number_layers=3:\
> > -ts_target_bitrate=250000,500000,1000000:ts_rate_decimator=4,2,1:\
> > -ts_periodicity=4:ts_layer_id=0,2,1,2 OUTPUT
> > +ts_target_bitrate=250,500,1000:ts_rate_decimator=4,2,1:\
> > +ts_periodicity=4:ts_layer_id=0,2,1,2:ts_layering_mode=3 OUTPUT
> > @end example
> > Below is a brief explanation of each of the parameters, please
> > refer to @code{struct vpx_codec_enc_cfg} in @code{vpx/vpx_encoder.h}
> for more
> > @@ -1903,13 +1901,28 @@ details.
> > @item ts_number_layers
> > Number of temporal coding layers.
> > @item ts_target_bitrate
> > -Target bitrate for each temporal layer.
> > +Target bitrate for each temporal layer in kbps.
> > +(bitrate should be inclusive of the lower temporal layer).
>
> This portion is a bug fix for the existing docs (bps -> kbps). Can you
> split this out to its own patch?
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
