> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Friday, November 29, 2019 04:51 AM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] libswscale/x86/yuv2rgb: add ssse3 > version > > On Thu, Nov 28, 2019 at 02:07:08PM +0800, Ting Fu wrote: > > Signed-off-by: Ting Fu <ting...@intel.com> > > --- > > libswscale/x86/yuv2rgb.c | 5 + > > libswscale/x86/yuv2rgb_template.c | 58 ++++++++++- > > libswscale/x86/yuv_2_rgb.asm | 163 +++++++++++++++++++++++++++--- > > 3 files changed, 208 insertions(+), 18 deletions(-) > > breaks build on x86-32 > make > X86ASM libswscale/x86/yuv_2_rgb.o > src/libswscale/x86/yuv_2_rgb.asm:400: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:331: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:400: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:332: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:400: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:333: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:401: error: label `BROADCAST' inconsistently > redefined > src/libswscale/x86/yuv_2_rgb.asm:331: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:400: note: label `BROADCAST' originally > defined here > src/libswscale/x86/yuv_2_rgb.asm:331: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:401: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:331: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:401: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:332: ... from macro `yuv2rgb_fn' defined > here > src/libswscale/x86/yuv_2_rgb.asm:401: error: parser: instruction expected > src/libswscale/x86/yuv_2_rgb.asm:333: ... from macro `yuv2rgb_fn' defined > here > make: *** [libswscale/x86/yuv_2_rgb.o] Error >
Hi Michael, This error comes from the macro define of BROADCAST only under ARCH_X86_64. And I have changed it into VBROADCASTSD(defined in x86util.asm) in PATCH V2. What's more, the md5 test passed in linux32/64 and windows64. Thank you for review. Ting Fu > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > I do not agree with what you have to say, but I'll defend to the death your > right > to say it. -- Voltaire _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
