> This is changing the muxer, but the commit subject and description talks about
> demuxing.
Yes. This code contains both the remuxer into MP4 and the demuxer. I will 
change the commit description
 
> You're calling this function for MPEGH 3D Audio, but not writing an
> implementation for it. The sgpd_entries array will be empty.
Thank you for pointing it out. 
In AAC case, the sgpd delay is set to -1 statically because most of popular AAC 
encoders have same encoder delay(1024 samples), but basically this value would 
be different for each encoder.
At this moment, there is no standard in MPEG-H 3D Audio so the value should not 
set statically.
In this patch, I'll remove this code. Most of media player could remove the 
encoder delay by using the edit list even if there is no sgpd box.

> Is every sample meant to be a Sync Sample?
No. The stss box is generated based on the sync frame flag information in 
MOVtrack. The sample MPEG-H 3D Audio content has sync frame in every 25 frame.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to