On Sat, 31. Aug 01:59, Marton Balint wrote: > > > On Fri, 30 Aug 2019, Andriy Gelman wrote: > > > Changes in v5: > > - Use polling in a loop to check interrupt callback. > > - Remove timeout_send/timeout_recv options and update > > documentation. > > Thanks, two comments: > > I noticed that you created a version requirement: libzmq >= 4.3.1. That is a > bit new. Are you actually using API which is not available or broken in > older releases? If yes, then OK. If not, then I'd relax this to 4.2.0 or > something around that release.
I had problems compiling 4.2.0, but tested 4.2.1 and it works fine. > > The other issue I can see is that you are using function names like > ff_zmq_*. That is a bit misleading, because in ffmpeg libraries ff_* > functions are common functions used from multiple C files. This is not the > case here, so please change the ff prefix of the static functions to > something else (e.g: zmq or zmqproto to not clash with real zmq library > function names). yes true, ff_* is misleading. I changed to zmq_proto_* Thanks, Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
